Skip to content

bug:fix runc delete run before delete exec.fifo #4735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

bug:fix runc delete run before delete exec.fifo #4735

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion libcontainer/container_linux.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,11 @@ func handleFifoResult(result openResult) error {
if err := readFromExecFifo(f); err != nil {
return err
}
return os.Remove(f.Name())
err := os.Remove(f.Name())
Copy link
Preview

Copilot AI May 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated error handling correctly ignores errors when exec.fifo does not exist, which fixes the bug. Consider adding a debug log when an unexpected error occurs to help diagnose issues in production environments.

Copilot uses AI. Check for mistakes.

if err == nil || os.IsNotExist(err) {
return nil
}
return err
}

type openResult struct {
Expand Down