Add UnionLink, etc. to the Atom Types. See #2816. #2843
Conversation
| // See issue opencog/atomspace#2814 for a discussion. | ||
| UNION_LINK <- OR_LINK | ||
| INTERSECTION_LINK <- AND_LINK | ||
| COMPLEMENT_LINK <- NOT_LINK |
There was a problem hiding this comment.
Cool! I'm not actually sure they should inherit OrLink, etc. But I guess we can revisit that later on.
There was a problem hiding this comment.
Yes, you are absolutely right... this was a rush job, I didn't give it any thought. The reason they should not is because ... the checkers.cc will notice that these inherit evaluatability, and thus will prevent you from saying (Union (Set (Concept "foo"))) Dohhh! So this needs to be patched! Which is what #2814 was all about...
It's past bedtime for me; you have any ideas of the correct inheritance for this?
There was a problem hiding this comment.
Seems like UnorderedLink is the most they should inherit from...!?
There was a problem hiding this comment.
#2844 fixes this. Review and merge if it looks right.
The pull req opencog#2843 was not quite right.
|
@linas, I've added the following wiki pages https://wiki.opencog.org/w/UnionLink I don't know if you agree with the equivalence definitions with OrLink, AndLink and NotLink respectively. If you don't, hold on just a bit cause I have a proposal I'm ready to write as soon as I have time for it (probably next week, cause I'm busy today with other matters, and writing this is probably gonna take a day) that might change your mind. |
|
Looks fine to me.If you mean the thing about IndicatorPredicate and PLN
semantics -- sure, whatever, PLN is it's own system. My biggest
worry/concern about PLN is performance, and not the actual rules in it.
…--linas
On Fri, Sep 10, 2021 at 2:35 AM Nil Geisweiller ***@***.***> wrote:
@linas <https://github.com/linas>, I've added the following wiki pages
https://wiki.opencog.org/w/UnionLink
https://wiki.opencog.org/w/IntersectionLink
https://wiki.opencog.org/w/ComplementLink
I don't know if you agree with the equivalence definitions with OrLink,
AndLink and NotLink respectively. If you don't, hold on just a bit cause I
have a proposal I'm ready to write as soon as I have time for it (probably
next week, cause I'm busy today with other matters, and writing this is
probably gonna take a day) that might change your mind.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2843 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAXBIBX6X76NUTB4YUAOUTUBGYKJANCNFSM5DXQU5RQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
--
Patrick: Are they laughing at us?
Sponge Bob: No, Patrick, they are laughing next to us.
|
Issue #2816 discusses this, its a continuation of #2814