Quick start fixes #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…herwise have to create the pvoutput.yml
In windows this produces a // in between https://pvoutput.org//service/r2/search which the website then returns a unuseful 404 error
…e order. I think this is because it came from a dictionary
|
Thanks loads for the pull request - looks great to me! (And great catch with the failure of os.join on Windows!) I'll merge now. (BTW, don't worry about the broken test - it's unrelated - the tests are failing with the master branch... something to do with PyTables - I'll start a new issue) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I was encountering similar errors to that as described in #38 , running on Windows. The first part was that I hadn't created the pvoutput.yml and also hadn't specified data_service_url. I think as the code was written, both of those were not truly optional.
The second point which took me a while to spot, was that the os.path.join on Windows was putting a double // inbetween '.org' and 'service'. When this is parsed to the API, you get a really unhelpful 404 error if you look in the browser console with this error displayed on page "The page you requested is missing or has an error."
Using urllib's urljoin solved this problem. I haven't tested this in Linux.
I think hazaioud ran into problems with the Python code appearing to freeze due to all the Retries. Reducing the number of Retries to one stops the code from appearing to hang.