Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add collate function + test #101

Merged
merged 2 commits into from
Dec 20, 2024
Merged

add collate function + test #101

merged 2 commits into from
Dec 20, 2024

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Dec 20, 2024

Pull Request

Description

Added a collate function that joins samples together. This was mainly copied from ocf-datapipes.
This is needed for training PVnet DA, using ocf-data-sampler batches, in order to join the samples together - openclimatefix/PVNet#289

#100

How Has This Been Tested?

CI tests

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

Copy link
Member

@dfulu dfulu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@peterdudfield peterdudfield merged commit 7d67873 into main Dec 20, 2024
6 checks passed
@peterdudfield peterdudfield deleted the issue/100-colatte-function branch December 20, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants