Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial validation function file #324 #331

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

itsbharatj
Copy link

@itsbharatj itsbharatj commented Mar 1, 2025

PR #324

Description

Detailed Description
In order to avoid seeing a matrix multiplication errors, it would be good to validate the sample going into a model.

Added features

  • add a function that can be called by the app, or other scripts.
  • This function will take in a sample, and the ml configruation like this
  • Check for nwp and satellite
  • Check the time dimension is the right size for the model
  • Check the channel dimension is the right size
  • Check the width and height is the right size
  • For site data, check there is enough data for the model. This might be linked with the time or sun features

Fixes # #324

How Has This Been Tested?

image

  • Yes

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@itsbharatj
Copy link
Author

@peterdudfield can you please review and run the remaining tests.

Thanks

@peterdudfield
Copy link
Contributor

@Sukh-P would you be able to review this?

@itsbharatj
Copy link
Author

Hey @Sukh-P, I hope you're doing well.
Just a kind follow up to review the PR

Thanks,
Bharat

@itsbharatj
Copy link
Author

@peterdudfield @Sukh-P, following up again. I understand you must be caught up, but your review will help us move forward.

Thanks,
Bharat

@Sukh-P
Copy link
Member

Sukh-P commented Mar 6, 2025

@itsbharatj thanks for having a go at this issue, I just want to flag that since this issue does not have the contributions-welcome tag on it which we are using as stated in our contributions guidelines here this won't be a priority for us to review/implement as we have found in our experience that these sort of issues are more efficient to handle internally, we can try to get back to you when we can but due to this being a busy period at OCF I apologise if there is delay, thanks

@itsbharatj
Copy link
Author

I understand, @Sukh-P. I was not aware of this guideline.

I'm really passionate about what you're building at OCF and genuinely want to contribute—not just for GSoC.

I’d greatly appreciate it if you could point me to some important issues/repos that require public contributions. I’d love to build on them.

Looking forward,
Bharat Jain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants