-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial validation function file #324 #331
base: main
Are you sure you want to change the base?
Conversation
b2ee14e
to
d2a1b58
Compare
for more information, see https://pre-commit.ci
@peterdudfield can you please review and run the remaining tests. Thanks |
@Sukh-P would you be able to review this? |
Hey @Sukh-P, I hope you're doing well. Thanks, |
@peterdudfield @Sukh-P, following up again. I understand you must be caught up, but your review will help us move forward. Thanks, |
@itsbharatj thanks for having a go at this issue, I just want to flag that since this issue does not have the contributions-welcome tag on it which we are using as stated in our contributions guidelines here this won't be a priority for us to review/implement as we have found in our experience that these sort of issues are more efficient to handle internally, we can try to get back to you when we can but due to this being a busy period at OCF I apologise if there is delay, thanks |
I understand, @Sukh-P. I was not aware of this guideline. I'm really passionate about what you're building at OCF and genuinely want to contribute—not just for GSoC. I’d greatly appreciate it if you could point me to some important issues/repos that require public contributions. I’d love to build on them. Looking forward, |
PR #324
Description
Detailed Description
In order to avoid seeing a matrix multiplication errors, it would be good to validate the sample going into a model.
Added features
Fixes # #324
How Has This Been Tested?
Yes
Yes
Checklist: