Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config related update - base_model #303

Closed
wants to merge 15 commits into from
Closed

Conversation

felix-e-h-p
Copy link
Contributor

Minor necessary updates in the functions make_clean_data_config and minimize_data_config relating to config updates.

I.e. altering "nwp_zarr_path" to "zarr_path".

Issue became apparent when pushing new model config to hugging face.

@peterdudfield peterdudfield marked this pull request as draft January 21, 2025 16:08
@dfulu
Copy link
Member

dfulu commented Jan 21, 2025

@felix-e-h-p we are purposely keeping the upgrade to data-sampler off the main branch until its fully ready - including the site stuff. We're using the dev-data-sampler branch until everything is done

@felix-e-h-p
Copy link
Contributor Author

@felix-e-h-p we are purposely keeping the upgrade to data-sampler off the main branch until its fully ready - including the site stuff. We're using the dev-data-sampler branch until everything is done

Yeah - ignore sorry, not to merge just draft. base_model related changes apparent when using the new config / data-sampler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants