-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PVNet for datasampler #302
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…x/PVNet into site-data-sampling
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good. Thanks for your thoroughness in these changes. I've just got a few questions and comments on here
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @Sukh-P. Can we make it a squash merge? We haven't in the past in this repo but I think it is much cleaner
Pull Request
Description
This PR includes:
Some updates have not been made in this PR and may be better suited to a separate PR to separate concerns and reduce PR size:
pv_encoder
in some places, I have left this in for now because there are some tests which rely on this (would need to update some HF files to get some from_pretrained tests to work)How Has This Been Tested?
Getting tests to pass & running training on some premade site samples.