Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PVNet for datasampler #302

Merged
merged 38 commits into from
Jan 21, 2025
Merged

Update PVNet for datasampler #302

merged 38 commits into from
Jan 21, 2025

Conversation

Sukh-P
Copy link
Member

@Sukh-P Sukh-P commented Jan 21, 2025

Pull Request

Description

This PR includes:

  • Updates PVNet to use the new batch format that ocf-data-sampler produces
  • Updates some of the model modules (such as site encoder) to work with samples from the sites data pipeline.
  • Some test data has been updated as well to reflect the new batch format

Some updates have not been made in this PR and may be better suited to a separate PR to separate concerns and reduce PR size:

  • Using the new SampleKeys rather than strings in places (TBD whether that is what we want)
  • Updating some of the network modules to the new batch format that aren't used as often (e.g one of the site encoders)
  • Naming consistency, use pv_encoder in some places, I have left this in for now because there are some tests which rely on this (would need to update some HF files to get some from_pretrained tests to work)

How Has This Been Tested?

Getting tests to pass & running training on some premade site samples.

Sukhil Patel and others added 30 commits December 17, 2024 16:17
@Sukh-P Sukh-P marked this pull request as ready for review January 21, 2025 11:25
@Sukh-P Sukh-P requested review from peterdudfield and dfulu January 21, 2025 11:25
Base automatically changed from site-data-sampling to dev-data-sampler January 21, 2025 11:57
Copy link
Member

@dfulu dfulu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good. Thanks for your thoroughness in these changes. I've just got a few questions and comments on here

Copy link
Member

@dfulu dfulu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @Sukh-P. Can we make it a squash merge? We haven't in the past in this repo but I think it is much cleaner

@Sukh-P Sukh-P merged commit 6d254db into dev-data-sampler Jan 21, 2025
3 checks passed
@Sukh-P Sukh-P deleted the fix-data-sampler branch January 21, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants