Fix sequence length for sites

openclimatefix · Jan 21, 2025 · 5624ad2 · 5624ad2
1 parent a060d15
commit 5624ad2
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/pvnet/models/multimodal/multimodal.py b/pvnet/models/multimodal/multimodal.py
@@ -221,7 +221,7 @@ def __init__(
             assert pv_history_minutes is not None
 
             self.pv_encoder = pv_encoder(
-                sequence_length=pv_history_minutes // pv_interval_minutes - 1,
+                sequence_length=pv_history_minutes // pv_interval_minutes + 1,
                 target_key_to_use=self._target_key_name,
                 input_key_to_use="site",
             )

diff --git a/pvnet/models/multimodal/site_encoders/encoders.py b/pvnet/models/multimodal/site_encoders/encoders.py
@@ -170,6 +170,7 @@ def __init__(
         self.input_key_to_use = input_key_to_use
         self.num_channels = num_channels
         self.num_sites_in_inference = num_sites_in_inference
+        print(self.sequence_length, 'SEQUENCE LENGTH')
 
         if use_id_in_value:
             self.value_id_embedding = nn.Embedding(num_sites, id_embed_dim)

diff --git a/tests/conftest.py b/tests/conftest.py
@@ -210,7 +210,7 @@ def site_encoder_model_kwargs():
 def site_encoder_model_kwargs_dsampler():
     # Used to test site encoder model on PV data
     kwargs = dict(
-        sequence_length=60 // 15 - 1, num_sites=1, out_features=128, target_key_to_use="site"
+        sequence_length=60 // 15 + 1, num_sites=1, out_features=128, target_key_to_use="site"
     )
     return kwargs