feat: add durable git share snapshots#64
Conversation
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: feat: add durable git share snapshots This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e146428a0d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return err | ||
| } | ||
| } else { | ||
| manifest, err = share.ImportAt(ctx, st, opts, *ref) |
There was a problem hiding this comment.
Avoid auto-updating before restoring refs
When share.auto_update is enabled and the reader archive is stale, a.openStore(cfg) has already run autoUpdateShare, which calls share.Pull and imports the latest manifest, before this --ref branch runs. In that default configuration, slacrawl update --ref <old-tag> can fast-forward the share checkout first (and an invalid ref still leaves the DB/repo updated to latest), contradicting the advertised non-mutating historical restore. Open the store without auto-update or bypass autoUpdateShare when --ref is set.
Useful? React with 👍 / 👎.
|
Landed in Proof: full tests, race tests, vet, dead-code analysis, and autoreview passed locally. GitHub tests, lint, dependency checks, Docker, release snapshot, CodeQL, secret scanning, and Socket security passed on the merged head. |
|
Post-merge verification completed against
The audit found one bounded omission: generated Bash/Zsh completions lacked the new flags. Fixed and landed in #65 ( |
Summary
publish --tagsnapshots and non-mutating historical restores withupdate --refProof
go test ./...go test -race ./...go vet ./...go run golang.org/x/tools/cmd/deadcode@v0.45.0 -test ./...