Repository navigation
refactor: centralize Gateway production and beta Store requests - #212
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs real behavior proof before merge. What this changesThis PR replaces native Microsoft Store publication with a manual request to the central release repository. Example: An operator selects Gateway build run 123.
Review scores
ProductKind: Refactor · Worth it: Yes · Fix scope: Complete Merge readiness⛔ Blocked before merge - 4 items remain Keep open: this maintainer-authored PR provides a useful publication boundary change that requires a coordinated central cutover. Priority: P2 Before merge
Findings
Tests
Agent review detailsHow this fits togetherPackaging produces the authorized multi-architecture bundle; the adapter forwards its build run ID, while the central publisher must own source validation, release-manager approval, credentials, and Store mutations. flowchart LR
A[Authorized Gateway build] --> B[Retained Store bundle]
A --> C[Manual request adapter]
C --> D[Central source validation]
B --> D
D --> E[Release manager approval]
E --> F[Central Store publisher]
F --> G[Microsoft Store]
Technical reviewBest possible solution: Complete the central publisher and administrative cutover first, preserving one authoritative publisher and the existing authorized bundle handoff. Do we have a high-confidence way to reproduce the issue? Source confirms that current main publishes locally and the PR instead dispatches the central workflow; no live publication or unauthorized-principal experiment was performed. Is this the best way to solve the issue? Central ownership is a coherent solution, and the adapter is small with no retired local callers found; its security outcome depends on completing the explicitly documented external cutover. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against dfa5d77d0a5c. Merge-risk optionsMaintainer options:
Provenance checked
TestingProof path: unit tests only. SecurityNeeds attention: The adapter has no concrete security defect, but effective central publication authority is not yet established. EvidenceSecurity concerns:
What I checked:
Likely related people:
Review metrics
LabelsLabel changes:
Label justifications:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed October 27, 2026, 2:07 PM ET / 18:07 UTC. |
|
One credential-scope concern to resolve before the cutover: the The Please bind the request job to a protected environment restricted to the exact Step 3 in
I haven't verified the deployed secret scope or App permissions, so this is a conditional exposure concern, not a confirmed leaked key or a demonstrated bypass of central Store approval. The workflow and setup instructions currently leave that credential boundary unspecified. |
What Problem This Solves
Gateway betas must reach the Store Development flight as well as GitHub prereleases, without leaving a second credential-bearing publisher in the packaging repository.
User Impact
There is no installed-product change. Packaging retains the signed beta prerelease, current-attempt Store bundle/source witness, shared revision-zero Store version allocation, and upgrade behavior from #246 and #247.
The native Store action becomes a main-only, manual recovery request to the standalone central publisher. Operators choose
productionordevelopment; acceptance means queued for central approval, not accepted by Microsoft. Automatic stable and beta handoff belongs to core #181446, which waits for packaging and requests Production for stable or the Development flight for beta.Why This Change Was Made
openclaw/releases/windows-store-publish.yml@mainwithproduct=gateway, a canonical positiverun_id, normalizedchannel, andautomatic=false.Stack and Activation
Do not activate on merge alone. Configure the central exact-main release-manager environment without bypass, eligible code owners and enforced review/CI rules, scoped existing App access, product identifiers, and exclusive central Entra federation. Remove the native trust after draining old runs/tokens.
Central repository variables
MSSTORE_GATEWAY_DEVELOPMENT_FLIGHT_IDandMSSTORE_GATEWAY_DEVELOPMENT_ENABLEDown beta activation. Keep automatic Development delivery disabled until a manually approved central submission, certification, and data-preserving tester upgrade are qualified. Both Store destinations retain release-manager approval. No new PAT or flight-specific identity/federation is required.Evidence
Validated signed head:
218217961be04ef965f668ca2be8ddebcc3bb71b.Integrated main:
59a981674c3091df2520f4d1655f4b07e4bf65fd.Validated/committed tree:
03d234b9f01fa23a7fa7a498e89a9974eb8f9c1e.Conflict resolution preserves the central request-only adapter and all landed #247 build/version/witness behavior. Newly landed tests for the retired native publisher were removed with their owner; the request workflow, adapter, and documentation retain their prior behavior.
Passed from the repository root in PowerShell 7 on macOS:
Test-Request-MicrosoftStorePublish.Tests.ps1: 22 scenarios.Test-SigningInputs.Tests.ps1andTest-WorkflowSigningConfiguration.ps1, including eight Store runner-preparation fixtures.Test-WorkflowPackageVersion.Tests.ps1,Test-MSIXUpgradeMatrix.Tests.ps1, andTest-PackagingRelevance.Tests.ps1.Test-DocReferences.ps1: 0 findings;actionlint .github/workflows/submit-microsoft-store.yml; staged and base-relativegit diff --check.Not run: managed quality/xUnit (no managed code changed by this residual), Windows NativeAOT/MSIX composition or installed upgrades, live App dispatch/approval/Store delivery, admin/federation cutover, artifact signing or release publication. New-head hosted CI is pending, not claimed green.
Coordinated Store Approval Rollout
Land evidence-writer compatibility before enforcing PR-only main. These PRs do not apply live settings, merge themselves, or authorize a Store submission.