Repository navigation
fix: Store submission fails when no pending draft is returned - #2252
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. What this changesThe PR permits an omitted pending-submission field during Store preflight while preserving strict ownership checks after draft creation. Example: Partner Center returns application 9NTESTOPENCLAW without PendingApplicationSubmission.
Review scores
ProductKind: Bug fix · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review Keep open: current main still rejects an omitted pending-draft field, and this maintainer-authored PR provides a focused repair with no actionable code findings. Priority: P2 Before mergeNone. FindingsNone. Agent review detailsHow this fits togetherThe protected Store workflow passes an authorized release bundle and publishing credentials to the PowerShell publisher, which checks Partner Center state, creates and verifies its draft, uploads the bundle, and records commit acceptance. flowchart TD
A[Authorized release bundle] --> B[Protected Store workflow]
B --> C[Publisher preflight]
C --> D[Partner Center draft creation]
D --> E[Explicit ownership checks]
E --> F[Upload and commit]
F --> G[Submission receipt]
Technical reviewBest possible solution: Land the focused preflight repair after the draft’s validation gates clear, retaining explicit draft ownership and the existing protected publication rollout. Do we have a high-confidence way to reproduce the issue? Current-main source deterministically throws when PendingApplicationSubmission is omitted; the reported stable submission failure matches that path, and the author reports a base-failing/head-passing fixture reproduction. Is this the best way to solve the issue? This is the smallest complete repair: relax only the existing preflight read, preserve positive ownership checks after creation, and cover both outcomes through the existing publisher fixture. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 177946621f0a. Provenance checked
TestingProof path: in-process harness. SecurityNone. EvidenceWhat I checked:
Likely related people:
Preflight sourceSource unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified. Review metrics
LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed November 16, 2026, 3:19 PM ET / 20:19 UTC. |
|
Resolved the modify/delete conflicts in 94aa4a4 by preserving the central publisher migration from #1891 (refactor(release): request central Companion Store publication). The retired native publisher and its tests remain deleted. The branch tree now exactly matches current main, so this PR has no remaining file changes and is superseded, not a candidate to restore the old publishing path. Verified central main already handles omitted pending pointers at preflight while requiring explicit ownership after creation, and includes both omission regression cases:
Validation: pwsh -NoProfile -File scripts/test-store-publication-request.ps1 passed all 31 scenarios; git diff --cached --check passed before commit; git diff origin/main HEAD --exit-code confirms identical trees. No new production-code delta remains. Full Windows closeout remains unavailable on this macOS host; no Windows or live Store success is claimed. No publication action was dispatched. |
What Problem This Solves
Fixes: Microsoft Store submission fails before creating a draft when Partner Center omits the pending-submission field.
User Impact
User impact: release operators can submit an update when the product has no pending draft. Existing drafts remain protected. Live publication is not yet verified.
Why This Change Was Made
Treat an omitted pending-submission property like explicit null only during preflight. Keep the post-creation ownership check strict, and preserve metadata, package mutation and ambiguous-commit safeguards.
Evidence
Failed stable submission run for
v2026.11.3:Store response is missing 'PendingApplicationSubmission'.The new omission regression fails with that same error on the original script and passes after repair. Added coverage also proves that omission after draft creation cannot authorize update/upload/commit. Existing foreign-draft and ambiguous-commit cases remain passing.Change Type
Scope
winnodeRequired proof pools
none: publisher response parsing only; no Windows app, installer, artifact construction or native runtime behavior changes. Protected main-only Store submission remains a separate post-merge proof obligation.Validation
pwsh -NoProfile -File scripts/test-microsoft-store-submission.ps1: PASS, full script suite including two new scenarios (suite does not emit a case count).git diff --check: PASS.pwsh -NoProfile -File build.ps1: BLOCKED, requires Windows.pwsh -NoProfile -File scripts/setup-dev.ps1 -CheckOnly: BLOCKED, requires Windows.dotnet test ... --no-restore: initially failed with NETSDK1004 in fresh worktree. Restore-enabled results below.Real Behavior Proof
59c7d4da183ef46e8f7af9728e90a2a0ab9d63cb.pwsh -NoProfile -File scripts/test-microsoft-store-submission.ps1.Microsoft Store submission tests passed.Security Impact
Yes, explain the risk and mitigation: N/A. Existing endpoints, credentials and draft guards unchanged.Compatibility and Migration
Review Conversations