feat: add Orgo provider#458
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed June 22, 2026, 5:05 AM ET / 09:05 UTC. Summary Reproducibility: not applicable. this is a new-provider feature PR, not a broken existing behavior report. The relevant verification path is live Orgo provider proof, and complete hosted create/run/delete proof is still missing. Review metrics: 2 noteworthy metrics.
Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Next step before merge
Security Review findings
Review detailsBest possible solution: Land Orgo only after maintainers confirm the built-in provider direction, the release-owned changelog edit is removed, and the PR includes redacted live hosted create/run/delete proof. Do we have a high-confidence way to reproduce the issue? Not applicable: this is a new-provider feature PR, not a broken existing behavior report. The relevant verification path is live Orgo provider proof, and complete hosted create/run/delete proof is still missing. Is this the best way to solve the issue? Unclear: the adapter follows Crabbox's delegated-run and credential-provenance patterns, but the built-in provider direction and final hosted service contract still need maintainer confirmation. Full review comments:
Overall correctness: patch is correct AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against f57d12b03d1f. Label changesLabel justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
d9aab2f to
482bc1b
Compare
ea50d4d to
8f551f1
Compare
Drives the real *orgoHTTPClient through the delegated-run backend against a fake Orgo REST API (httptest), covering the full lifecycle: create workspace, create computer, run bash, delete computer, delete workspace. Asserts the Bearer auth header, exit code, SyncDelegated, stdout, and that every expected API endpoint is hit. No real secrets: the API key is a dummy value via CRABBOX_ORGO_API_KEY and the base URL is the in-process test server via CRABBOX_ORGO_API_BASE, so the test never reaches the live Orgo API. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Regenerated internal/cli/provider_categories_generated.go via scripts/generate-provider-matrix.mjs so the benchmark provider categories include orgo (delegated-sandbox). Keeps scripts/check-docs.sh green after rebasing onto latest main. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
8f551f1 to
6709b30
Compare
Summary
Verification
node --test scripts/live-smoke.test.jsshellcheck -e SC2016 scripts/live-smoke.shnode scripts/check-provider-matrix.mjsbash scripts/check-docs.shgo vet ./...go test ./...(first aggregate hit existing flakyinternal/clitest, focused rerun passed, second aggregate passed)go test -race ./...(first aggregate hit existing flakyinternal/clitests, focused rerun passed, second aggregate passed)go build -trimpath -o bin/crabbox ./cmd/crabboxbin/crabboxfake-Orgo-API e2e covering create workspace, create computer, bash command, delete computer, and delete workspacenpm run format:check --prefix workernpm run lint --prefix workernpm run check --prefix workernpm test --prefix workernpm run build --prefix workersk_live_pattern inHEADSecret/config notes
The Orgo API key is intentionally environment/config only and is not exposed as a CLI flag. I did not run the live Orgo smoke against a real pasted key; the live smoke is build/test ready, and local e2e used a fake API with a dummy key.
Refs #449
Authenticated account validation
Exact head
6709b303333df8d29ddd92c79fd4877bd8ba29d2was rebuilt and retested after rebasing onto currentmain:doctorpassed real Orgo authentication, control-plane, and inventory checks.listdecoded the live/workspaces{"projects":[]}envelope and reported an empty account. This exposed and fixed the workspace-envelope compatibility bug with a regression test.Full remote bash/delete lifecycle proof remains blocked on paid-plan authorization. This PR should not merge under the live-proof requirement until that temporary subscription is explicitly approved and the computer is deleted after validation.