[codex] improve ClawHub diversion handoff#342
Conversation
|
Codex review: needs maintainer review before merge. Reviewed June 20, 2026, 8:07 PM ET / 00:07 UTC. Summary Reproducibility: not applicable. This PR changes close-comment rendering and prompt policy rather than reporting a reproducible bug. Source inspection plus the PR body's rendered output are enough to review the behavior. Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Next step before merge
Security Review detailsBest possible solution: Keep the narrow handoff in the existing ClawHub close path so contributors get package guidance while ClawSweeper remains out of creating or publishing ClawHub work. Do we have a high-confidence way to reproduce the issue? Not applicable; this PR changes close-comment rendering and prompt policy rather than reporting a reproducible bug. Source inspection plus the PR body's rendered output are enough to review the behavior. Is this the best way to solve the issue? Yes; a reason-gated render helper plus focused prompt and renderer tests is a narrow maintainable way to improve ClawHub close comments. Current main does not already provide this handoff block. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 1566ad6a0a5b. Label changesLabel justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
| @@ -406,6 +406,7 @@ Close only when the evidence is strong and the repository policy allows it. Allo | |||
| - `mostly_implemented_on_main`: an older PR is more than 60 days old, current `main` already implements the central useful part of the PR, and no meaningful unique remainder should be merged from the branch. Use only for pull requests, not issues. The close comment must say what part is already on `main`, what leftover part is minor/obsolete/superseded or separately tracked, and why keeping the stale branch open is not useful. | |||
Summary
This makes ClawSweeper's
clawhubclose path more useful when an OpenClaw issue or PR belongs in ClawHub rather than core.clawhubclose comments with package scope, manifest/checklist basics, and an explicit self-serve boundary.bestSolutionandcloseCommentidentify likely package shape and checklist details for skills, plugins, providers, channels, bundles, or MCP integrations.Why
The current close copy says to upload or publish through ClawHub, but it does not give the contributor enough practical next steps. This adds the useful part of a ClawHub diversion lane without making ClawSweeper mutate another repo or do the ClawHub packaging for the contributor.
Rendered Output Proof
Rendered through the built
dist/clawsweeper.jsclose-comment path withreviewActionForDecision. The sample issue metadata is synthetic/redacted; the output below is produced by the real renderer on this branch.Validation
pnpm install --frozen-lockfilepnpm run buildpnpm exec oxfmt --check src/clawsweeper.ts test/clawsweeper.test.ts test/review-prompt-policy.test.tspnpm run lint:srcpnpm run lint:scriptsnode --test --test-name-pattern "ClawHub closes a self-serve handoff|skill-only OpenClaw PRs can close through ClawHub" test\review-prompt-policy.test.ts test\clawsweeper.test.tscodex -c 'service_tier="fast"' review --uncommittedreturned no actionable findings.Note: running the whole
test/clawsweeper.test.tsfile on this Windows worktree hit an unrelated CRLF-sensitive workflow fixture assertion. The two affected tests pass with the targeted test-name filter above.