Repository navigation
feat(openai): enable GPT-6.2 compaction and input-token counting - #1126
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Taking the maintainer review and landing pass for this existing PR at Jason’s request. I have the latest 5be4728, including Hannes’s compact-test correction; script-tests is now green. I will preserve both commits and attribution, independently verify the narrow API-key capability/product additions, and recheck the head before any push or merge. Please flag any active follow-up edits here so we avoid overlapping writes. No release or deployment is part of this pass. |
|
Codex review: needs maintainer review before merge. What this changesEnable GPT-6.2 Astra and Sol on the existing API-key compaction and input-token-counting routes. Example: POST /v1/responses/input_tokens with model openai/gpt-6.2-sol and input Hello.
Review scores
ProductKind: Feature · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review Keep open: this maintainer-authored PR adds useful capabilities absent from main and has an active maintainer landing pass; source review found no introduced correctness defect. Priority: P2 Before mergeNone. FindingsNone. Tests
Agent review detailsHow this fits togetherProvider YAML compiles into the Worker catalog, which combines model capabilities and product offers with existing policy, credential, account-affinity, and budget checks before upstream dispatch. flowchart LR
A[Provider manifest] --> B[Compiled catalog]
C[API request] --> D[Model and offer selection]
B --> D
D --> E[Policy credentials and budgets]
E --> F[OpenAI endpoint]
F --> G[Response and usage settlement]
Technical reviewBest possible solution: Retain the focused manifest additions and generated catalog while reusing the existing routing, authorization, and accounting owners. Do we have a high-confidence way to reproduce the issue? Main's model capabilities and explicit offers omit these model/endpoint pairs, and current selection code requires them; this is source-verifiable without running target code. Is this the best way to solve the issue? The manifest-only extension fits the existing architecture, preserves established account and budget restrictions, and avoids unnecessary handlers or adapters. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 4a434ef28516. Provenance checked
TestingProof path: in-process harness. SecurityNone. EvidenceWhat I checked:
Likely related people:
Preflight sourceSource unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified. LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed November 17, 2026, 6:33 PM ET / 23:33 UTC. |
|
Maintainer verification completed at
ClawSweeper’s exact-head review also reports no findings and no before-merge blocker. Live provider smoke testing remains outside this landing pass under the release/deployment hold. Waiting for the remaining exact-head consumer checks; no release or deployment is being performed. |
Summary
Let API-key callers use the existing
/v1/responses/compactand/v1/responses/input_tokensroutes withopenai/gpt-6.2-astraandopenai/gpt-6.2-sol. Add both model IDs to the matching platform API offers and add the two capabilities to their model cards. Regenerate the provider snapshot. No changes to handlers, pricing, model defaults, or subscription offers. The compact manifest test checks the routing rule with two synthetic Responses models instead of pinning an ordered list of production IDs.Verification
All 90 provider manifests compiled with the candidate YAML. The compiled catalog contains the four expected model/endpoint pairs for the platform API only. Existing model pricing is unchanged. 260 focused tests passed locally against this candidate (compact manifest and Worker routing, token counting, and GPT-6.2). A negative control that incorrectly allowed every Responses model to use compaction failed the new test on the ordinary Responses-only fixture, as intended. These are synthetic checks, not live inference proof.
Deployment status
Not deployed. Verify both routes against the deployed catalog after rollout.
Remaining risk
Existing account-affinity, grant and budget checks still apply. This enables standalone compaction and stateless token counting, not Batch or unrestricted multi-agent compaction. Compaction guide · Token counting.