Repository navigation
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. What this changesAdds authenticated remote Codex model catalogs and an opt-in connection mode that preserves existing local connections. Example: Connect Codex 0.169.0 to gpt-6-sol with --catalog-mode remote.
Review scores
ProductKind: Feature · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review Keep open: this maintainer-authored PR adds a useful capability absent from main, and inspection found no concrete implementation defect. Priority: P2 Before mergeNone. FindingsNone. Tests
Agent review detailsHow this fits togetherThe Worker authenticates catalog requests, resolves existing inference eligibility and credentials, fetches upstream descriptors, and returns privately cached metadata filtered to authorized models and tiers. flowchart LR
A[Codex client] --> B[Worker catalog endpoint]
B --> C[Existing authorization and offers]
C --> D[Selected OpenAI credential]
D --> E[Upstream model descriptors]
E --> F[Shared catalog projection]
F --> A
Technical reviewBest possible solution: Retain the opt-in endpoint and existing connection owners, preserve released local connections, and keep production activation separately gated. Do we have a high-confidence way to reproduce the issue? This is a new capability; current main demonstrably uses local catalogs, and the supplied fixtures exercise the proposed remote path. Is this the best way to solve the issue? The implementation reuses existing authorization, credential selection, catalog projection, and configuration ownership rather than introducing competing decision paths. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against e2727c39ddda. Provenance checked
TestingProof path: in-process harness. SecurityNone. EvidenceWhat I checked:
Preflight sourceSource unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified. LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment HistoryReview history (1 earlier review cycle)
Reviewed November 17, 2026, 6:57 PM ET / 23:57 UTC (Revision 2). |
|
@clawsweeper re-review Please review current head
The tests verify that released receipts load without rewriting, updates preserve local mode, remove/reconnect explicitly enables remote mode, native clients fetch the actual Worker catalog endpoint, unauthorized models and unpriced tiers are filtered, Daybreak descriptors survive, synthetic inference succeeds, and authentication/unrelated configuration survive update and removal. Desktop Hosted native proof: all 82 tests passed, zero failures or skips. The four cases emit explicit evidence diagnostics in that log. All current-head checks have passed: CI, consumer contract, and CodeQL. These are isolated actual-runtime/native-client results with a synthetic upstream, not production or entitled Daybreak Blue inference proof. The source deployment hold remains enabled; production activation is outside this PR's authorization. |
|
🦞👀 Re-review progress:
|
Summary
Custom Codex providers can omit current model metadata and access programs when using a generated local catalog. Add opt-in authenticated
GET /v1/codex/modelsdiscovery andcodex-connect --catalog-mode remote, allowing Codex to refresh complete versioned descriptors through the account and routing policy eligible for inference.Preserve upstream instructions, unknown metadata and access programs while narrowing models/service tiers to authorized Responses offers. Keep caller/credential/policy caches private and bounded. Keep the catalog route outside the native inference artifact. Add pinned Codex 0.169 coverage. Repair a LiteLLM fixture ordering issue reproduced on unchanged main, preserving every assertion. Include a source deployment hold while qualifying the combined release.
Verification
6a51eead, all 11 CI jobs, all 46 consumer workflow jobs and CodeQL passed.608050e4). Released receipts verify without rewriting, remain local through update, and remove/reconnect explicitly enables remote mode. Native clients fetch the actual Worker endpoint, receive filtered model/tier metadata, and complete synthetic inference. Desktop model-list exposes the current display name and Daybreak programs. Auth and unrelated configuration survive update/remove. All four new cases and the complete 82-test native client group passed locally and in hosted CI, with zero skips/failures. CI runs these with the pinned release source. These are synthetic isolated behavior/upgrade results, not production or entitled Blue inference proof. Hosted re-review remains required.Deployment status
Ready for review; not merged, not release-qualified, not deployed. Candidate
6a51eeadb08be94ae1a62701733623e2bfc6ee88; base4a434ef28516c74d3ca0452431f6ce27b0dfc294. Production-based fallback preserved separately.The included
hold:truemakes scheduled production rollout a no-op and blocks manual/train selection after source landing. Hosted qualification requires reviewed main plus successful exact-source main-push CI. Source landing is authorized after CI and hosted ClawSweeper review are clear; production activation remains separately authorized.Authorized rehearsal setup: created a dedicated temporary Cloudflare token (expires November 18, 23:00 UTC) and a
native-qualificationGitHub environment restricted tomain, with dedicated Cloudflare/account/admin secrets. Existing credentials and production resources unchanged; no rehearsal compute/storage resources provisioned. A bounded GET probe confirms account/token consistency, subscription access and live capacity. Metered billable usage remains 403 despite Billing Read; costs unknown.Remaining risk
Main includes native changes beyond production; the catalog itself remains edge-only. Four fresh isolated synthetic cutover/recovery fixtures, actual saved-session/accounting/recovery evidence, cleanup verification and a reviewed registry entry remain required. The native qualification registry is empty. Temporary credentials must be removed after rehearsal/expiry. No production rollout is authorized by this PR.
Remote discovery establishes metadata visibility, not Daybreak Blue inference. The prior live Blue request returned upstream
403 access_program_not_enabled. Retest after authorized deployment, retaining the assumption that the deployed key has Blue access.