Add fast-agent to the Agents list#351
Conversation
|
Codex review: found issues before merge. Reviewed May 29, 2026, 1:20 PM ET / 17:20 UTC. Summary Reproducibility: yes. for the review findings: current-main source inspection shows unknown agent names fall through as raw commands, and the branch adds a Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review findings
Review detailsBest possible solution: Land this only after maintainers explicitly accept the reserved Do we have a high-confidence way to reproduce the issue? Yes for the review findings: current-main source inspection shows unknown agent names fall through as raw commands, and the branch adds a Is this the best way to solve the issue? Unclear: the implementation is narrow and the PR body includes live startup proof, but reserving a new positional name is a maintainer product decision. If maintainers accept the name, the docs ordering and neutral-placement issues should be repaired before merge. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model gpt-5.5, reasoning high; reviewed against f6de6dd18aae. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
* feat: add fast-agent built-in adapter * Add fast-agent to the Agents list (#351) * update capitalization, naming, use fast-agent.ai site * docs: normalize fast-agent naming --------- Co-authored-by: shaun smith <1936278+evalstate@users.noreply.github.com>
This is an update to PR #350 by @osolmaz to normalise the name to
fast-agentand point directly to the fast-agent.ai website. Tested.Original text below.
Opened on behalf of Onur Solmaz (
osolmaz). This PR is ready for review.Summary
acpxdid not have a friendly built-in name for EvalState fast-agent.This change adds
acpx fast-agentand points it at the fast-agent ACP entrypoint,uvx fast-agent-mcp acp.The first convenience wrapper I tried,
uvx fast-agent-acp, failed in a live startup test with a missing Python module, so the PR now uses the main fast-agent package command that actually initializes and serves ACP.It also updates the supported-agent docs, the acpx skill, and tests so the new adapter is visible and verified like the other built-ins.
AI-assisted: yes.
I understand the change: it adds one registry mapping, documents the required
uvxdependency, and tests that the CLI resolves the new built-in command correctly.What Changed
The runtime registry now knows how to launch fast-agent through ACP.
The docs now list fast-agent anywhere the built-in registry is described.
fast-agent -> uvx fast-agent-mcp acpto the built-in agent registry.agents/FastAgent.mdand updated the README, docs site, install docs, acpx skill, and changelog.Testing
This was tested with focused checks, full repo validation, and a real local fast-agent ACP run.
The live test used
uvx,fast-agent-mcp0.7.13, and a temporaryfast-agent.yamlpointed at a local Ollamaqwen2.5:0.5bmodel.pnpm run build:test && node --test dist-test/test/agent-registry.test.js dist-test/test/integration.test.jspnpm run check:docspnpm run checknode dist/cli.js --timeout 60 --format json fast-agent exec "Reply with exactly: acpx fast-agent live ok"when the built-in still useduvx fast-agent-acp; it failed before initialize withModuleNotFoundError: No module named 'fast_agent_acp'.fast-agent.yaml(default_model: generic.qwen2.5:0.5b, local Ollama generic provider),node dist/cli.js --cwd "$tmp_cwd" --timeout 90 --format json fast-agent exec "Reply with exactly: acpx fast-agent live ok"initialized ACP, created a session, streamed assistant message chunks, and returnedstopReason: end_turn.Risks
The risk is low because this only adds a registry mapping and docs.
The main operational requirement is that users need
uvxavailable onPATHand fast-agent model/provider configuration for real prompts.