Skip to content

fix: clean up related records when deleting entities #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anonymoususer72041 wants to merge 6 commits into
base: master
Choose a base branch
from

Add entity delete cleanup regression tests

043af70
Select commit
Loading
Failed to load commit list.
Open

fix: clean up related records when deleting entities #769

Add entity delete cleanup regression tests
043af70
Select commit
Loading
Failed to load commit list.
Codacy Production / Codacy Static Code Analysis required action May 30, 2026 in 0s

8 new issues (0 max.) of at least severity.

Codacy Here is an overview of what got changed by this pull request:

Issues
======
- Added 8
           

Complexity increasing per file
==============================
- src/OpenCATS/Tests/IntegrationTests/EntityDeleteCleanupTest.php  7
- modules/install/scripts/379.php  19

See the complete overview on Codacy

Annotations

Check warning on line 7 in modules/install/scripts/379.php

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

modules/install/scripts/379.php#L7 

The function update_379() has 401 lines of code. Current threshold is set to 100. Avoid really long methods.

Check warning on line 7 in modules/install/scripts/379.php

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

modules/install/scripts/379.php#L7 

The function update_379() has a Cyclomatic Complexity of 19. The configured cyclomatic complexity threshold is 10.

Check warning on line 7 in modules/install/scripts/379.php

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

modules/install/scripts/379.php#L7 

The function update_379() has an NPath complexity of 12534. The configured NPath complexity threshold is 200.

Check notice on line 10 in modules/install/scripts/379.php

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

modules/install/scripts/379.php#L10 

Avoid excessively long variable names like $orphanAttachmentDirectories. Keep variable name length under 20.

Check notice on line 12 in modules/install/scripts/379.php

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

modules/install/scripts/379.php#L12 

Avoid excessively long variable names like $orphanAttachmentDirectoriesRS. Keep variable name length under 20.

Check warning on line 16 in src/OpenCATS/Tests/IntegrationTests/EntityDeleteCleanupTest.php

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/OpenCATS/Tests/IntegrationTests/EntityDeleteCleanupTest.php#L16 

setUp accesses the super-global variable $_SESSION.

Check warning on line 56 in src/OpenCATS/Tests/IntegrationTests/EntityDeleteCleanupTest.php

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/OpenCATS/Tests/IntegrationTests/EntityDeleteCleanupTest.php#L56 

Avoid using static access to class '\DatabaseConnection' in method 'testJobOrderDeleteResetsGeneralAndCalendarReferences'.

Check notice on line 171 in src/OpenCATS/Tests/IntegrationTests/EntityDeleteCleanupTest.php

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/OpenCATS/Tests/IntegrationTests/EntityDeleteCleanupTest.php#L171 

Avoid excessively long variable names like $questionnaireHistoryID. Keep variable name length under 20.
View more details on Codacy Production