Skip to content

Conversation

@Arnei
Copy link
Member

@Arnei Arnei commented Feb 25, 2025

Updates eslint to major version 9 and removes other eslint dependencies that are obsolete. Furthermore, adds typescript and eslint checks to the build command, so that warnings and errors must be addressed. Finally, makes the minimum amount of code changes for this to build. Currently ignored eslint rules may be enabled by subsequent commits/pull requests.

@Arnei Arnei added type:dependencies Pull requests that update a dependency file type:infrastructure Build process, deployment, workflows type:code-quality Internal improvements to the codebase labels Feb 25, 2025
@github-actions
Copy link

This pull request is deployed at test.editor.opencast.org/1558/2025-02-25_11-34-43/ .
It might take a few minutes for it to become available.

@gregorydlogan
Copy link
Member

So, I'm thinking that #1134 is related here. Can we enforce the tabs vs spaces debate here too? Sounds like everything else (editor, tobira, OC itself) is all spaces, so enforcing a spaces change with this might make sense.

@Arnei
Copy link
Member Author

Arnei commented Mar 10, 2025

I don't see how that PR is related at all, maybe you got the wrong number?

Also this PR enforces the no-tabs eslint rule again, which enforces using spaces for indentation (unless people try using some other unholy whitespace character for indentation I guess).

@Arnei Arnei requested a review from gregorydlogan April 1, 2025 11:39
@owi92
Copy link

owi92 commented Apr 4, 2025

lgtm. @gregorydlogan, I'm also a little puzzled by that linked issue 😄
Feel free to have another look at this, but otherwise I'd say this can be merged.

@gregorydlogan
Copy link
Member

Yep, that was meant to be opencast/opencast-admin-interface#1134. As long as we're consistent tabs vs spaces wise I'm happy.

@Arnei Arnei merged commit c6bc719 into opencast:main Apr 7, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:code-quality Internal improvements to the codebase type:dependencies Pull requests that update a dependency file type:infrastructure Build process, deployment, workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants