-
Notifications
You must be signed in to change notification settings - Fork 45
Update and enforce eslint #1558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updates eslint to major version 9 and removes other eslint dependencies that are obsolete. Furthermore, adds typescript and eslint checks to the build command, so that warnings and errors must be addressed. Finally, makes the minimum amount of code changes for this to build. Currently ignored eslint rules may be enabled by subsequent commits/pull requests.
|
This pull request is deployed at test.editor.opencast.org/1558/2025-02-25_11-34-43/ . |
|
So, I'm thinking that #1134 is related here. Can we enforce the tabs vs spaces debate here too? Sounds like everything else (editor, tobira, OC itself) is all spaces, so enforcing a spaces change with this might make sense. |
|
I don't see how that PR is related at all, maybe you got the wrong number? Also this PR enforces the |
|
lgtm. @gregorydlogan, I'm also a little puzzled by that linked issue 😄 |
|
Yep, that was meant to be opencast/opencast-admin-interface#1134. As long as we're consistent tabs vs spaces wise I'm happy. |
Updates eslint to major version 9 and removes other eslint dependencies that are obsolete. Furthermore, adds typescript and eslint checks to the build command, so that warnings and errors must be addressed. Finally, makes the minimum amount of code changes for this to build. Currently ignored eslint rules may be enabled by subsequent commits/pull requests.