Css color consistency #1431
Open
Css color consistency #1431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace more fontawesome icons with lucide icons and remove all fontawesome css files.
We are not using the accordion capabiltiies anywhere.
Clearfix helps with certain "float" issues. In our code it was either added unnecessarily, or the issue could be solved in another way easily enough.
Removes some css that does not go together with other css, according to sass.
Removes lots of leftover corrections that we do not need anymore.
Move css to more appropriate places. Only movement, no changes.
And either crete new files or put it in the appropriate places.
integrate the css for modals from main to modal-base
We have a bunch of css concerning colors flying around in our tsx files. To ensure our colors are consistent in the future, this patch moves the css into our scss files and replaces hex codes with variables.
While the use of the "style" attribute can be necessary in many cases, we mostly seem to use it because we were too lazy to put the css in it's proper place in the scss files. Let's remedy that.
These don't exist anymore, so we can remove them.
Make more dropdowns have the same background and text color for hovered options.
Make the published cell in the events table look like other cells with similar appearance.
In the table heeader, fix both sorting chevrons being colored as "active", instead of only one. Also make the active chevron darker to be more easily recognizable.
Arnei
added
type:code-enhancement
Contributor
|
This pull request has conflicts ☹ |
Contributor
|
Use Run test server using develop.opencast.org as backend: Specify a different backend like stable.opencast.org: It may take a few seconds for the interface to spin up. |
Contributor
|
This pull request has conflicts ☹ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes #1400. #1400 Should be reviewed and merged first.
This PR replaces the "hardcoded" color values that are flying around everywhere in our scss files with the color variables defined in
_variables.scss. Color values that are not represented by our variables are either added to the variables file, or replaced with a variable with a similar value.Goals:
How to test this
This touches every element that has color, so unfortunately pretty much everything. Quickly click through everything ui element you can find and check if any colors appear "off".