Series and events permissions override enhancement #1295
Conversation
ferishili
added
priority:critical
|
Use Run test server using develop.opencast.org as backend: Specify a different backend like stable.opencast.org: It may take a few seconds for the interface to spin up. |
|
This pull request is deployed at test.admin-interface.opencast.org/1295/2025-05-19_11-59-08/ . |
Arnei
left a comment
Arnei
left a comment
There was a problem hiding this comment.
The configuration key admin.series.acl.event.update.mode seems to be missing in the backend. At least I could not find it. If it should exist, could you add it?
|
|
||
| const orgProperties = useAppSelector(state => getOrgProperties(state)); | ||
|
|
||
| const overrideEnabled = (orgProperties['admin.series.acl.event.update.mode'] || 'optional').toLowerCase() === 'optional'; |
There was a problem hiding this comment.
Aren't there supposed to be three modes, always, never and optional? Can that really be represented with a boolean?
There was a problem hiding this comment.
You are right!
in this place to check and offer the button if it is optional is correct.
what is missing is to make sure that never & always are also in the play!
It is under |
Sorry for troubling you, but could you point out the line in the file? I'm really not seeing it in https://github.com/opencast/opencast/blob/r/17.x/etc/org.opencastproject.organization-mh_default_org.cfg |
No worries, it seems that it is missing in 17.x but it is there in 16.x! However, the documentation for 17.x says it is still effectively there: https://docs.opencast.org/r/17.x/admin/#configuration/acl/#updating-series-permissions [UPDATE]: @Arnei, I found the patch that removed the settings, it appears to me that this setting is removed considering it is related to old admin-ui which shouldn't! |
:D Then would you do Lars the favor of adding it back to 17.x, just like it was in 16.x? |
|
This pull request has conflicts ☹ |
|
This pull request has conflicts ☹ |
|
Thanks for this PR @ferishili. I did test this PR with our test environment where we have merge mode "actions" configured. Setting If I configure However, the behaviour of
In our test environment, "always" and "never" behave exactly the same. As I understand it, when changing the series ACLs, the event ACLs should be removed and replaced with the new series ACLs. This is equivalent to the "Save series and overwrite event permissions" button with the |
… optional modal button
|
Rebased this onto r/17.x, as this is "fixing" a feature introduced with r/17.x (which was main at the time). |
|
I'm seeing wonky behaviour locally which I can't reproduce with legacy.opencast.org: Screencast.from.2025-09-23.15-28-21.mp4This happens every time you modify the permissions for an unsaved role. So at the end of the video, if I went back and modified ROLE_ADMIN's permissions everything would work fine. If, however, I added a different role then it would reset the new role's dropdown to "Select or create a role" every time I change the permission - either adding, or removing it. |
4 participants
This PR fixes #1290,
It introduces the optional offering of the button for the "overwrite of the events" when saving the series acl based on the config:
admin.series.acl.event.update.modeas to beingoptionalor empty to offer both buttons!The button label and hint also got slightly more meaningful texts.
NOTE: At the time of creating this PR there is a commit/PR missing from
develop(default) which makes the user and system perm separation, hence the permission dialogs are broken! So, please usestable.opencast.orgin order to test!