Add OAuth2 scope support #156
Open
+181
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3461f7c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lionello
commented
Jan 16, 2025
| @@ -38,22 +38,22 @@ | |||
| * | |||
| * @packageDocumentation | |||
| */ | |||
| import type { v1 } from "@standard-schema/spec" | |||
There was a problem hiding this comment.
These got reordered because of Organize Imports. Let me know if you want me to revert this part.
lionello
commented
Jan 16, 2025
| * } | ||
| * ``` | ||
| */ | ||
| scopes_supported?: string[] |
There was a problem hiding this comment.
This would also be a good place to add default_scopes or so, which would be used if the auth request has no scope.
lionello
commented
Jan 16, 2025
.changeset/new-donuts-tap.md
Outdated
There was a problem hiding this comment.
Not sure if this is right. Haven't used this before either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5
First time contributing and new to bun/hono, so let me know if something is out of style. Particularly not sure about usage of
test.eachfor testing with and without scopes.The OAuth2 spec is pretty thin wrt
scope. In particular, the corner cases seem to differ between implementations. For this PR, I've considered the absence ofscopedifferent from the empty scope, ie.&scope=. Additionally, in the token/refresh request I ignore scopes that were not part of the auth request, instead of for example returninginvalid_scopeerror.Since the resource server will have to check the issued scopes, I've added
scopesto the JWT, iffscopewas specified in the auth request.