forked from Azure/azure-rest-api-specs
-
Notifications
You must be signed in to change notification settings - Fork 3
Support ad test 1 #3627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ruowan
wants to merge
9
commits into
main
Choose a base branch
from
support-ad-test-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Support ad test 1 #3627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swagger Validation Report
|
compared tags (via openapi-validator v2.0.0) | new version | base version |
---|---|---|
release_1_1 | release_1_1(55518ad) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
Only 30 items are listed, please refer to log for more details.
Rule | Message | Related RPC [For API reviewers] |
---|---|---|
OperationIdNounVerb |
Per the Noun_Verb convention for Operation Ids, the noun 'Multivariate' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: AnomalyDetector/stable/v1.1/openapi.json#L70 |
|
OperationIdNounVerb |
Per the Noun_Verb convention for Operation Ids, the noun 'Multivariate' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: AnomalyDetector/stable/v1.1/openapi.json#L112 |
|
OperationIdNounVerb |
Per the Noun_Verb convention for Operation Ids, the noun 'Multivariate' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: AnomalyDetector/stable/v1.1/openapi.json#L159 |
|
OperationIdNounVerb |
Per the Noun_Verb convention for Operation Ids, the noun 'Multivariate' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: AnomalyDetector/stable/v1.1/openapi.json#L213 |
|
OperationIdNounVerb |
Per the Noun_Verb convention for Operation Ids, the noun 'Multivariate' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: AnomalyDetector/stable/v1.1/openapi.json#L249 |
|
OperationIdNounVerb |
Per the Noun_Verb convention for Operation Ids, the noun 'Multivariate' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: AnomalyDetector/stable/v1.1/openapi.json#L290 |
|
OperationIdNounVerb |
Per the Noun_Verb convention for Operation Ids, the noun 'Multivariate' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: AnomalyDetector/stable/v1.1/openapi.json#L350 |
|
OperationIdNounVerb |
Per the Noun_Verb convention for Operation Ids, the noun 'Univariate' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: AnomalyDetector/stable/v1.1/openapi.json#L400 |
|
OperationIdNounVerb |
Per the Noun_Verb convention for Operation Ids, the noun 'Univariate' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: AnomalyDetector/stable/v1.1/openapi.json#L443 |
|
OperationIdNounVerb |
Per the Noun_Verb convention for Operation Ids, the noun 'Univariate' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: AnomalyDetector/stable/v1.1/openapi.json#L486 |
|
API version should be a date in YYYY-MM-DD format, optionally suffixed with '-preview'. Location: AnomalyDetector/stable/v1.1/openapi.json#L5 |
||
Security definition should have a description. Location: AnomalyDetector/stable/v1.1/openapi.json#L60 |
||
Based on the response model schema, operation 'Multivariate_GetMultivariateBatchDetectionResult' might be pageable. Consider adding the x-ms-pageable extension. Location: AnomalyDetector/stable/v1.1/openapi.json#L69 |
||
Operation might be pageable. Consider adding the x-ms-pageable extension. Location: AnomalyDetector/stable/v1.1/openapi.json#L69 |
||
Operation does not define an 'api-version' query parameter. Location: AnomalyDetector/stable/v1.1/openapi.json#L73 |
||
Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: AnomalyDetector/stable/v1.1/openapi.json#L74 |
||
Error response schema should contain an object property named error .Location: AnomalyDetector/stable/v1.1/openapi.json#L98 |
||
Operation does not define an 'api-version' query parameter. Location: AnomalyDetector/stable/v1.1/openapi.json#L115 |
||
Using post for a create operation is discouraged. Location: AnomalyDetector/stable/v1.1/openapi.json#L127 |
||
Error response schema should contain an object property named error .Location: AnomalyDetector/stable/v1.1/openapi.json#L147 |
||
Operation does not define an 'api-version' query parameter. Location: AnomalyDetector/stable/v1.1/openapi.json#L162 |
||
Response body schema of pageable response should contain top-level array property value Location: AnomalyDetector/stable/v1.1/openapi.json#L184 |
||
Error response schema should contain an object property named error .Location: AnomalyDetector/stable/v1.1/openapi.json#L196 |
||
Operation does not define an 'api-version' query parameter. Location: AnomalyDetector/stable/v1.1/openapi.json#L216 |
||
Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: AnomalyDetector/stable/v1.1/openapi.json#L217 |
||
Error response schema should contain an object property named error .Location: AnomalyDetector/stable/v1.1/openapi.json#L237 |
||
Operation does not define an 'api-version' query parameter. Location: AnomalyDetector/stable/v1.1/openapi.json#L252 |
||
Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: AnomalyDetector/stable/v1.1/openapi.json#L253 |
||
Error response schema should contain an object property named error .Location: AnomalyDetector/stable/v1.1/openapi.json#L276 |
||
Operations with a 202 response should specify x-ms-long-running-operation: true .Location: AnomalyDetector/stable/v1.1/openapi.json#L289 |
️️✔️
PR Summary succeeded [Detail] [Expand]
️️✔️
[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️❌
ModelValidation: 38 Errors, 0 Warnings failed [Detail]
Only 30 items are listed, please refer to log for more details.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️
~[Staging] SwaggerAPIView succeeded [Detail] [Expand]
️❌
~[Staging] CadlAPIView: 0 Errors, 1 Warnings failed [Detail]
Rule | Message |
---|---|
"How to fix":"Check the detailed log and update cadl version to latest." |
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️⚠️
[Staging] SDK Track2 Validation: 1 Warnings warning [Detail]
- The following tags are being changed in this PR
- "https://github.com/openapi-env-test/azure-rest-api-specs/blob/55518ad9b4ef89697acaf143d5234cc8431b9a72/specification/cognitiveservices/data-plane/AnomalyDetector/readme.md#tag-release_1_1">cognitiveservices/data-plane/AnomalyDetector/readme.md#release_1_1
Rule | Message |
---|---|
"readme":"cognitiveservices/data-plane/AnomalyDetector/readme.md", "tag":"release_1_1", "details":"Security scheme ApiKeyAuth is unknown and will not be processed. Only supported types are AADToken, AzureKey, Anonymous" |
️❌
CadlValidation: 2 Errors, 10 Warnings failed [Detail]
Rule | Message |
---|---|
@azure-tools/cadl-azure-core/key-visibility-required |
The key property 'resultId' does not have an explicit visibility setting, please use the @visibility decorator to set it. Location: cognitiveservices/AnomalyDetector/multivariate/models.cadl#L50 |
@azure-tools/cadl-azure-core/key-visibility-required |
The key property 'modelId' does not have an explicit visibility setting, please use the @visibility decorator to set it. Location: cognitiveservices/AnomalyDetector/multivariate/models.cadl#L314 |
Operation 'DetectUnivariateEntireSeries' should be defined using a signature from the Azure.Core namespace. Location: cognitiveservices/AnomalyDetector/univariate/routes.cadl#L10 |
|
Operation 'DetectUnivariateLastPoint' should be defined using a signature from the Azure.Core namespace. Location: cognitiveservices/AnomalyDetector/univariate/routes.cadl#L26 |
|
Operation 'DetectUnivariateChangePoint' should be defined using a signature from the Azure.Core namespace. Location: cognitiveservices/AnomalyDetector/univariate/routes.cadl#L40 |
|
Operation 'GetMultivariateBatchDetectionResult' should be defined using a signature from the Azure.Core namespace. Location: cognitiveservices/AnomalyDetector/multivariate/routes.cadl#L10 |
|
Operation 'TrainMultivariateModel' should be defined using a signature from the Azure.Core namespace. Location: cognitiveservices/AnomalyDetector/multivariate/routes.cadl#L25 |
|
Operation 'ListMultivariateModels' should be defined using a signature from the Azure.Core namespace. Location: cognitiveservices/AnomalyDetector/multivariate/routes.cadl#L52 |
|
Operation 'DeleteMultivariateModel' should be defined using a signature from the Azure.Core namespace. Location: cognitiveservices/AnomalyDetector/multivariate/routes.cadl#L67 |
|
Operation 'GetMultivariateModel' should be defined using a signature from the Azure.Core namespace. Location: cognitiveservices/AnomalyDetector/multivariate/routes.cadl#L82 |
|
Operation 'DetectMultivariateBatchAnomaly' should be defined using a signature from the Azure.Core namespace. Location: cognitiveservices/AnomalyDetector/multivariate/routes.cadl#L96 |
|
Operation 'DetectMultivariateLastAnomaly' should be defined using a signature from the Azure.Core namespace. Location: cognitiveservices/AnomalyDetector/multivariate/routes.cadl#L131 |
Swagger Generation Artifacts
|
Generated ApiView
|
This was referenced Jan 9, 2023
Closed
/azp run |
No pipelines are associated with this pull request. |
/azp run |
No pipelines are associated with this pull request. |
/azp run |
No pipelines are associated with this pull request. |
/azp run |
No pipelines are associated with this pull request. |
/azp run |
No pipelines are associated with this pull request. |
/azp run |
No pipelines are associated with this pull request. |
/azp run |
No pipelines are associated with this pull request. |
/azp run |
No pipelines are associated with this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.