Skip to content
This repository was archived by the owner on Aug 28, 2025. It is now read-only.

Dw/test new folder structure#3617

Open
dw511214992 wants to merge 4 commits intomainfrom
dw/test-new-folder-structure
Open

Dw/test new folder structure#3617
dw511214992 wants to merge 4 commits intomainfrom
dw/test-new-folder-structure

Conversation

@dw511214992
Copy link
Copy Markdown

@dw511214992 dw511214992 commented Dec 7, 2022

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-pipeline-app-test
Copy link
Copy Markdown

openapi-pipeline-app-test Bot commented Dec 7, 2022 •
edited
Loading

Swagger Validation Report

️⌛BreakingChange pending [Detail]
️⌛Breaking Change(Cross-Version) pending [Detail]
️⌛LintDiff pending [Detail]
️⌛PR Summary pending [Detail]
️⌛[Staging] Lint(RPaaS) pending [Detail]
️⌛Avocado pending [Detail]
️⌛ModelValidation pending [Detail]
️⌛SemanticValidation pending [Detail]
️⌛ApiReadinessCheck pending [Detail]
️⌛~[Staging] SwaggerAPIView pending [Detail]
️⌛CredScan pending [Detail]
️⌛PoliCheck pending [Detail]
️⌛[Staging] PrettierCheck pending [Detail]
️⌛[Staging] SpellCheck pending [Detail]
️⌛[Staging] SDK Track2 Validation pending [Detail]
️⌛CadlValidation pending [Detail]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app-test
Copy link
Copy Markdown

openapi-pipeline-app-test Bot commented Dec 7, 2022 •
edited
Loading

Swagger Generation Artifacts

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand] 
 Please click here to preview with your @microsoft account.
️️✔️[Staging] SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking


Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app-test
Copy link
Copy Markdown

openapi-pipeline-app-test Bot commented Dec 7, 2022 •
edited
Loading

Swagger pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

@azure-sdk azure-sdk mentioned this pull request Dec 7, 2022
Closed
@dw511214992
Copy link
Copy Markdown
Author

dw511214992 commented Dec 7, 2022

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Dec 7, 2022

No pipelines are associated with this pull request.

@dw511214992
Copy link
Copy Markdown
Author

dw511214992 commented Dec 7, 2022

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Dec 7, 2022

No pipelines are associated with this pull request.

@dw511214992
Copy link
Copy Markdown
Author

dw511214992 commented Dec 7, 2022

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Dec 7, 2022

No pipelines are associated with this pull request.

@azure-sdk azure-sdk mentioned this pull request Dec 7, 2022
Closed
@msyyc msyyc mentioned this pull request Dec 7, 2022
Merged
@msyyc
Copy link
Copy Markdown

msyyc commented Dec 7, 2022

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Dec 7, 2022

No pipelines are associated with this pull request.

@azure-sdk azure-sdk mentioned this pull request Dec 7, 2022
Closed
@chunyu3
Copy link
Copy Markdown

chunyu3 commented Dec 9, 2022

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Dec 9, 2022

No pipelines are associated with this pull request.

@dw511214992
Copy link
Copy Markdown
Author

dw511214992 commented Dec 9, 2022

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Dec 9, 2022

No pipelines are associated with this pull request.

@dw511214992
Copy link
Copy Markdown
Author

dw511214992 commented Dec 9, 2022

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Dec 9, 2022

No pipelines are associated with this pull request.

@dw511214992
Copy link
Copy Markdown
Author

dw511214992 commented Dec 9, 2022

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Dec 9, 2022

No pipelines are associated with this pull request.

@dw511214992
Copy link
Copy Markdown
Author

dw511214992 commented Dec 9, 2022

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Dec 9, 2022

No pipelines are associated with this pull request.

@azure-sdk azure-sdk mentioned this pull request Dec 9, 2022
Closed
@chunyu3
Copy link
Copy Markdown

chunyu3 commented Dec 9, 2022

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Dec 9, 2022

No pipelines are associated with this pull request.

@dw511214992
Copy link
Copy Markdown
Author

dw511214992 commented Dec 12, 2022

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Dec 12, 2022

No pipelines are associated with this pull request.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@msyyc msyyc Awaiting requested review from msyyc

@ArcturusZhang ArcturusZhang Awaiting requested review from ArcturusZhang

@qiaozha qiaozha Awaiting requested review from qiaozha

@mikekistler mikekistler Awaiting requested review from mikekistler

Assignees

@ruowan ruowan

Labels

cadl CI-FixRequiredOnFailure CI-MissingBaseCommit CI-NewRPNamespaceWithoutRPaaS data-plane new-api-version new-rp-namespace

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dw511214992 @msyyc @chunyu3 @ruowan @AzureRestAPISpecReview