Tih/test cdn #2642

PhoenixHe-NV · 2021-04-26T03:19:48Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-pipeline-app-test · 2021-04-26T03:19:51Z

Swagger Validation Report

️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.8.9)
- original: stable/2020-09-01/cdn.json <---> new: stable/2020-09-01/cdn.json

Rule	Message
`❌` 1035 - RemovedOperation	The new version is missing an operation that was found in the old version. Was operationId 'Profiles_Get' removed or restructured? New: Microsoft.Cdn/stable/2020-09-01/cdn.json#L118:5 Old: Microsoft.Cdn/stable/2020-09-01/cdn.json#L118:5

️❌LintDiff: 1 Errors, 1 Warnings failed [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.9.2 , classic-openapi-validator v1.1.6 )
- cdn/resource-manager/readme.md tag:package-2020-09
Linted configuring files (Based on target branch, openapi-validator v1.9.2 , classic-openapi-validator v1.1.6 )
- cdn/resource-manager/readme.md tag:package-2020-09

The following errors/warnings are introduced by current PR:

Rule	Message
`❌` R3025 - TrackedResourceGetOperation	Tracked resource 'Profile' must have a get operation. Location: Microsoft.Cdn/stable/2020-09-01/cdn.json#L2392
⚠️ R4014 - AllResourcesMustHaveGetOperation	The resource 'Profile' does not have get operation, please add it. Location: Microsoft.Cdn/stable/2020-09-01/cdn.json#L2392

The following errors/warnings exist before current PR submission:

Only 10 items are listed, please refer to log for more details.

Rule	Message
`❌` R3021 - PathResourceTypeNameCamelCase	Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cdn/CdnWebApplicationFirewallPolicies' Location: Microsoft.Cdn/stable/2020-09-01/cdnwebapplicationfirewall.json#L37
`❌` R3021 - PathResourceTypeNameCamelCase	Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cdn/CdnWebApplicationFirewallPolicies/{policyName}' Location: Microsoft.Cdn/stable/2020-09-01/cdnwebapplicationfirewall.json#L79
`❌` R3021 - PathResourceTypeNameCamelCase	Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/providers/Microsoft.Cdn/CdnWebApplicationFirewallManagedRuleSets' Location: Microsoft.Cdn/stable/2020-09-01/cdnwebapplicationfirewall.json#L274
`❌` R4005 - UniqueXmsEnumName	Must not have duplicate name of x-ms-enum extension , make sure every x-ms-enum name unique. The duplicate x-ms-enum name: matchvariable, path: $.DeliveryRuleCondition.properties.name Location: Microsoft.Cdn/stable/2020-09-01/cdnwebapplicationfirewall.json#L604
`❌` R4007 - DefaultErrorResponseSchema	the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content. Location: Microsoft.Cdn/stable/2020-09-01/cdn.json#L64
`❌` R4007 - DefaultErrorResponseSchema	the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content. Location: Microsoft.Cdn/stable/2020-09-01/cdn.json#L106
`❌` R4007 - DefaultErrorResponseSchema	the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content. Location: Microsoft.Cdn/stable/2020-09-01/cdn.json#L176
`❌` R4007 - DefaultErrorResponseSchema	the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content. Location: Microsoft.Cdn/stable/2020-09-01/cdn.json#L236
`❌` R4007 - DefaultErrorResponseSchema	the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content. Location: Microsoft.Cdn/stable/2020-09-01/cdn.json#L281
`❌` R4007 - DefaultErrorResponseSchema	the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content. Location: Microsoft.Cdn/stable/2020-09-01/cdn.json#L328

️❌Avocado: 1 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` UNREFERENCED_JSON_FILE	The example JSON file is not referenced from the swagger file. readme: specification/cdn/resource-manager/readme.md json: stable/2020-09-01/examples/Profiles_Get.json

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app-test · 2021-04-26T03:19:52Z

Swagger Generation Artifacts

️🔄[Staging] ApiDocPreview inProgress [Detail]

️❌[Staging] UpdateTracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-python-track2 - track2_azure-mgmt-cdn - Approved - 11.0.0

+	Removed operation ProfilesOperations.get

❌azure-sdk-for-go - cdn/mgmt/2020-09-01/cdn - Approved - v53.4.0

+	- Function `LogAnalyticsClient.GetLogAnalyticsMetricsPreparer` parameter(s) have been changed from `(context.Context, string, string, []string, date.Time, date.Time, string, []string, []string, []string, []string, []string)` to `(context.Context, string, string, []LogMetric, date.Time, date.Time, LogMetricsGranularity, []string, []string, []LogMetricsGroupBy, []string, []string)`
+	- Function `LogAnalyticsClient.GetLogAnalyticsMetrics` parameter(s) have been changed from `(context.Context, string, string, []string, date.Time, date.Time, string, []string, []string, []string, []string, []string)` to `(context.Context, string, string, []LogMetric, date.Time, date.Time, LogMetricsGranularity, []string, []string, []LogMetricsGroupBy, []string, []string)`
+	- Function `LogAnalyticsClient.GetLogAnalyticsRankingsPreparer` parameter(s) have been changed from `(context.Context, string, string, []string, []string, int32, date.Time, date.Time, []string)` to `(context.Context, string, string, []LogRanking, []LogRankingMetric, int32, date.Time, date.Time, []string)`
+	- Function `LogAnalyticsClient.GetLogAnalyticsRankings` parameter(s) have been changed from `(context.Context, string, string, []string, []string, int32, date.Time, date.Time, []string)` to `(context.Context, string, string, []LogRanking, []LogRankingMetric, int32, date.Time, date.Time, []string)`
+	- Function `LogAnalyticsClient.GetWafLogAnalyticsMetricsPreparer` parameter(s) have been changed from `(context.Context, string, string, []string, date.Time, date.Time, string, []string, []string, []string)` to `(context.Context, string, string, []WafMetric, date.Time, date.Time, WafGranularity, []WafAction, []WafRankingGroupBy, []WafRuleType)`
+	- Function `LogAnalyticsClient.GetWafLogAnalyticsMetrics` parameter(s) have been changed from `(context.Context, string, string, []string, date.Time, date.Time, string, []string, []string, []string)` to `(context.Context, string, string, []WafMetric, date.Time, date.Time, WafGranularity, []WafAction, []WafRankingGroupBy, []WafRuleType)`
+	- Function `LogAnalyticsClient.GetWafLogAnalyticsRankingsPreparer` parameter(s) have been changed from `(context.Context, string, string, []string, date.Time, date.Time, int32, []string, []string, []string)` to `(context.Context, string, string, []WafMetric, date.Time, date.Time, int32, []WafRankingType, []WafAction, []WafRuleType)`
+	- Function `LogAnalyticsClient.GetWafLogAnalyticsRankings` parameter(s) have been changed from `(context.Context, string, string, []string, date.Time, date.Time, int32, []string, []string, []string)` to `(context.Context, string, string, []WafMetric, date.Time, date.Time, int32, []WafRankingType, []WafAction, []WafRuleType)`
+	- Function `ProfilesClient.GetPreparer` has been removed
+	- Function `ProfilesClient.GetResponder` has been removed
+	- Function `ProfilesClient.GetSender` has been removed
+	- Function `ProfilesClient.Get` has been removed
+	- Function `RuleSetsClient.CreatePreparer` parameter(s) have been changed from `(context.Context, string, string, string, RuleSet)` to `(context.Context, string, string, string)`
+	- Function `RuleSetsClient.Create` parameter(s) have been changed from `(context.Context, string, string, string, RuleSet)` to `(context.Context, string, string, string)`

️✔️azure-sdk-for-go - cdn/mgmt/2020-04-15/cdn - Approved - v53.4.0
️✔️azure-sdk-for-go - cdn/mgmt/2019-06-15/cdn - Approved - v53.4.0
️✔️azure-sdk-for-go - cdn/mgmt/2019-04-15/cdn - Approved - v53.4.0
️✔️azure-sdk-for-go - cdn/mgmt/2017-10-12/cdn - Approved - v53.4.0
️✔️azure-sdk-for-go - cdn/mgmt/2017-04-02/cdn - Approved - v53.4.0
️✔️azure-sdk-for-go - cdn/mgmt/2016-10-02/cdn - Approved - v53.4.0
️✔️azure-sdk-for-go - cdn/mgmt/2016-04-02/cdn - Approved - v53.4.0
️✔️azure-sdk-for-go - cdn/mgmt/2015-06-01/cdn - Approved - v53.4.0

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs] Generate from ca63c6939b08358082c86d04a1295326b793041d. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️track2_azure-mgmt-cdn [View full logs] [Preview SDK Changes] Breaking Change Detected
- azure_mgmt_cdn-2.0.0-py2.py3-none-any.whl
- azure-mgmt-cdn-2.0.0.zip
```
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Removed operation ProfilesOperations.get
```

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from ca63c6939b08358082c86d04a1295326b793041d. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️cdn/mgmt/2020-09-01/cdn [View full logs] [Preview SDK Changes] Breaking Change Detected

Only show 14 items here, please refer to log for details.

info	[Changelog] - New function `PossibleWafMetricValues() []WafMetric`
info	[Changelog] - New function `PossibleLogMetricValues() []LogMetric`
info	[Changelog] - New function `PossibleLogRankingValues() []LogRanking`
info	[Changelog] - New function `PossibleLogRankingMetricValues() []LogRankingMetric`
info	[Changelog] - New function `PossibleWafGranularityValues() []WafGranularity`
info	[Changelog] - New function `PossibleLogMetricsGroupByValues() []LogMetricsGroupBy`
info	[Changelog] - New function `PossibleWafActionValues() []WafAction`
info	[Changelog] - New function `PossibleWafRankingTypeValues() []WafRankingType`
info	[Changelog] - New function `PossibleWafRuleTypeValues() []WafRuleType`
info	[Changelog] - New field `SystemData` in struct `ManagedRuleSetDefinition`
info	[Changelog] - New field `SystemData` in struct `Resource`
info	[Changelog]
info	[Changelog] Total 14 breaking change(s), 59 additive change(s).
info	[Changelog]

️✔️cdn/mgmt/2020-04-15/cdn [View full logs] [Preview SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️cdn/mgmt/2019-06-15/cdn [View full logs] [Preview SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️cdn/mgmt/2019-04-15/cdn [View full logs] [Preview SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️cdn/mgmt/2017-10-12/cdn [View full logs] [Preview SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️cdn/mgmt/2017-04-02/cdn [View full logs] [Preview SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️cdn/mgmt/2016-10-02/cdn [View full logs] [Preview SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️cdn/mgmt/2016-04-02/cdn [View full logs] [Preview SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️cdn/mgmt/2015-06-01/cdn [View full logs] [Preview SDK Changes]
```
info	[Changelog] No exported changes
```

_{Posted by Swagger Pipeline | How to fix these errors?}

PhoenixHe-NV · 2021-04-26T04:31:06Z

/azp run

azure-pipelines · 2021-04-26T04:31:14Z

No pipelines are associated with this pull request.

PhoenixHe-NV · 2021-04-27T02:35:00Z

/azp run

azure-pipelines · 2021-04-27T02:35:06Z

No pipelines are associated with this pull request.

Phoenix He added 2 commits April 25, 2021 16:02

Update 1 (#2635)

03fa3fe

Update 2 (#2639)

c705b4e

openapi-pipeline-app-test bot added the CI-BreakingChange-Go label Apr 26, 2021

azure-sdk force-pushed the master branch from de6d30f to dff40b8 Compare April 26, 2021 15:01

openapi-pipeline-app-test bot added the BreakingChangeReviewRequired label Apr 27, 2021

openapi-sdkautomation-test bot mentioned this pull request Apr 27, 2021

[AutoPR track2_azure-mgmt-cdn] Tih/test cdn openapi-env-test/azure-sdk-for-python#879

Closed

openapi-pipeline-app-test bot added the CI-BreakingChange-Python-Track2 label Apr 27, 2021

azure-sdk force-pushed the master branch from 3ec43b4 to d3c3277 Compare April 27, 2021 03:01

PhoenixHe-NV added Approved-SdkBreakingChange-Go Approved-SdkBreakingChange-Python labels Apr 27, 2021

azure-sdk force-pushed the master branch from fa294d1 to 29d616d Compare April 27, 2021 15:02

PhoenixHe-NV force-pushed the master branch from 29d616d to c5e4863 Compare April 28, 2021 01:34

azure-sdk force-pushed the master branch 3 times, most recently from f49e5ad to a70c2b0 Compare April 29, 2021 03:01

azure-sdk force-pushed the main branch 9 times, most recently from 1607e3f to 18a0704 Compare March 3, 2022 03:02

azure-sdk force-pushed the main branch 6 times, most recently from f705c8f to f16d6f0 Compare March 10, 2022 15:03

azure-sdk force-pushed the main branch from 96477cb to ba348cf Compare June 7, 2022 02:21

azure-sdk force-pushed the main branch 9 times, most recently from e61d481 to cbc85d7 Compare July 21, 2022 15:04

azure-sdk force-pushed the main branch 2 times, most recently from 8bae5b5 to 3ec6574 Compare August 9, 2022 15:05

AzureRestAPISpecReview removed the BreakingChangeReviewRequired label Sep 28, 2022

MaryGao force-pushed the main branch 2 times, most recently from c9d3abd to ff6b6bf Compare March 24, 2023 10:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Tih/test cdn #2642

Tih/test cdn #2642

Uh oh!

PhoenixHe-NV commented Apr 26, 2021

Uh oh!

openapi-pipeline-app-test bot commented Apr 26, 2021 •

edited

Loading

Uh oh!

openapi-pipeline-app-test bot commented Apr 26, 2021 •

edited

Loading

Breaking Changes Tracking

Uh oh!

PhoenixHe-NV commented Apr 26, 2021

Uh oh!

azure-pipelines bot commented Apr 26, 2021

Uh oh!

PhoenixHe-NV commented Apr 27, 2021

Uh oh!

azure-pipelines bot commented Apr 27, 2021

Uh oh!

Uh oh!

Tih/test cdn #2642

Are you sure you want to change the base?

Tih/test cdn #2642

Uh oh!

Conversation

PhoenixHe-NV commented Apr 26, 2021

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

Uh oh!

openapi-pipeline-app-test bot commented Apr 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

openapi-pipeline-app-test bot commented Apr 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Breaking Changes Tracking

Uh oh!

PhoenixHe-NV commented Apr 26, 2021

Uh oh!

azure-pipelines bot commented Apr 26, 2021

Uh oh!

PhoenixHe-NV commented Apr 27, 2021

Uh oh!

azure-pipelines bot commented Apr 27, 2021

Uh oh!

Uh oh!

openapi-pipeline-app-test bot commented Apr 26, 2021 •

edited

Loading

openapi-pipeline-app-test bot commented Apr 26, 2021 •

edited

Loading