-
Notifications
You must be signed in to change notification settings - Fork 9.8k
GitHub Actions: Add Python 3.13 to the testing #2487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hey, |
@jongwook Tests on Python 3.13 now pass with the new versions of @rdinkel When you think a pull request is useful and is ready to be merged, please consider giving it a positive review. Every check mark ✔️ at the top right of this page gives project maintainers confidence that the proposed changes have been read through and deemed both useful and safe to merge into the codebase. Lots of 👍 and "what is the ETA?" comments are easier for maintainers to ignore than ✔️✔️✔️✔️✔️ from several different reviewers. Anyone can review a pull request on GitHub. To do so here:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks ok
@cclauss |
You are correct in this case. |
How will this issue be proceeded going forward to get it done? |
Can this be merged, please? Python 3.13 has been out for a while now. |
For anyone testing things out, Python 3.13 does not work for me with installation until I make this change to diff --git a/setup.py b/setup.py
index 73c4eb8..eab80ed 100644
--- a/setup.py
+++ b/setup.py
@@ -7,8 +7,11 @@ from setuptools import find_packages, setup
def read_version(fname="whisper/version.py"):
- exec(compile(open(fname, encoding="utf-8").read(), fname, "exec"))
- return locals()["__version__"]
+ local_vars = {}
+ global_vars = {} # unused
+ with open(fname, encoding="utf-8") as f:
+ exec(compile(f.read(), fname, "exec"), global_vars, local_vars)
+ return local_vars["__version__"]
requirements = [] locals() docs describe the history of changes. With the above patch the |
Python 3.14 beta 1 is now available too, |
Python 3.13 was blocked waiting on
numba>=0.61.0
-- https://pypi.org/project/numba/#history andtriton>3.1.0
-- https://pypi.org/project/triton/#historybut now the PyPI releases of both are compatible with Python 3.13.