Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change order of justification key in eval schema #1619

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dylanjcastillo
Copy link

@dylanjcastillo dylanjcastillo commented Jan 1, 2025

Summary

In the meta-prompting notebook, you break the LLM judge's CoT reasoning by putting the justification key at the end of the schema. This results in lower-quality output.

cc @teomusatoiu

Copy link

@WutherHeights WutherHeights left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why this is necessary.

@dylanjcastillo
Copy link
Author

@WutherHeights IMO justification acts as a reasoning step. Not having it before the actual scores would mean that the scores don't really come from the reasoning/justification but that the justification is adjusted to whatever score was given.

This is similar to this change in the custom LLM judge notebook from the cookbook: e3e9fc2

image

See also: https://dylancastillo.co/posts/llm-pydantic-order-matters.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants