feat(tui): Display keyboard shortcuts inline for approval options #5889

0xRaduan · 2025-10-28T20:40:12Z

Shows single-key shortcuts (y, a, n) next to approval options to make them more discoverable. Previously these shortcuts worked but were hidden, making the feature hard to discover.

Changes:

"Yes, proceed" now shows "y" shortcut
"Yes, and don't ask again" now shows "a" shortcut
"No, and tell Codex..." continues to show "esc" shortcut

This improves UX by surfacing the quick keyboard shortcuts that were already functional but undiscoverable in the UI.

Update:

added parentheses for better visual clarity

github-actions · 2025-10-28T20:40:22Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

0xRaduan · 2025-10-28T20:40:45Z

I have read the CLA Document and I hereby sign the CLA

0xRaduan · 2025-10-28T20:52:10Z

oh, interesting. it's a claude commit - so it doesn't pass the CLA. @codex - can you push the same commit, but under your email?

chatgpt-codex-connector · 2025-10-28T20:52:18Z

Note

To use Codex here, create an environment for this repo.

0xRaduan · 2025-10-28T20:52:58Z

@codex - try one more time

chatgpt-codex-connector · 2025-10-28T20:53:06Z

Note

To use Codex here, create an environment for this repo.

Shows single-key shortcuts (y, a, n) next to approval options to make them more discoverable. Previously these shortcuts worked but were hidden, making the feature hard to discover. Changes: - "Yes, proceed" now shows "y" shortcut - "Yes, and don't ask again" now shows "a" shortcut - "No, and tell Codex..." continues to show "esc" shortcut This improves UX by surfacing the quick keyboard shortcuts that were already functional but undiscoverable in the UI. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

0xRaduan · 2025-10-28T20:55:25Z

Awesome, it works now :D

etraut-openai · 2025-11-04T05:07:09Z

@codex review

chatgpt-codex-connector · 2025-11-04T05:09:11Z

Codex Review: Didn't find any major issues. 👍

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Format code according to project style guidelines.

0xRaduan · 2025-11-04T08:30:28Z

@etraut-openai - fixed the cargo-fmt

Update test snapshots for approval modal to include the now-visible keyboard shortcuts (y, a) that were previously hidden. The shortcuts were always functional but are now displayed inline to improve discoverability. Updated snapshots: - approval_modal_exec: shows 'y' and 'a' shortcuts - approval_modal_exec_no_reason: shows 'y' and 'a' shortcuts - approval_modal_patch: shows 'y' shortcut - status_widget_and_approval_modal: shows 'y' and 'a' shortcuts Fixes 5 failing tests: - approval_modal_exec_snapshot - approval_modal_exec_without_reason_snapshot - approval_modal_patch_snapshot - exec_approval_emits_proposed_command_and_decision_history - status_widget_and_approval_modal_snapshot

Wrap keyboard shortcuts in parentheses to make them more visually distinct from option text and clearly indicate they are shortcut keys. Changes: - Modified selection_popup_common.rs to render shortcuts as " (key)" instead of " key" - Updated all approval modal snapshots to reflect the new format UI change: Before: "1. Yes, proceed y" After: "1. Yes, proceed (y)" This follows common UI patterns and improves visual clarity, making shortcuts more obvious and easier to scan.

0xRaduan · 2025-11-05T10:54:15Z

@etraut-openai – thanks for your reviews!

updated the code(fixed tests snapshots) + also added parentheses for better visual clarity on what's the text vs what's the shortcut

Update the snapshot for exec_approval_emits_proposed_command_and_decision_history test that was missed in the previous commit. This snapshot also needs to show keyboard shortcuts in parentheses.

etraut-openai · 2025-11-05T22:47:50Z

Thanks for the update. I see a couple of issues still.

The first paren appears as bolded whereas the remainder does not. Here's what I'm seeing when I run it.

The CI tests are failing because the insta snapshots have failed. We use a tool called insta to verify that the TUI text is as expected. It uses a snapshotting mechanism. To update the snapshots, you'll need to install insta (cargo install cargo-instal) and then run cargo test followed by cargo insta pending-snapshots and cargo insta accept. This should update the related snapshot, and you can commit that new shapshot file.

etraut-openai · 2025-11-05T22:48:53Z

BTW, I asked our designer to review this change, and he gave it the thumbs up. He's going to look at adding this pattern to more places in the TUI.

- Changed selection styling to use Style::default() instead of additive styling to prevent dim modifier from keyboard hints being preserved - Updated exec_approval_modal_exec snapshot to reflect consistent bold styling across entire selected line including shortcuts - Fixed issue where "(y)" shortcut appeared non-bold while "Yes, proceed" was bold 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

0xRaduan · 2025-11-08T12:03:37Z

Hi @etraut-openai,

Thanks for the feedback! I've addressed both issues:

Bolding inconsistency: Fixed the issue where only part of the selected option was bold. The entire selected line (including keyboard shortcuts in parentheses) now appears consistently bold and cyan.
Snapshot updates: Re-ran the tests, reviewed the snapshot changes with cargo insta, and committed the updated snapshot file.

All changes are in commit f3d1424. The CI should now pass - feel free to re-run it.

etraut-openai · 2025-11-08T17:04:41Z

@codex review

chatgpt-codex-connector · 2025-11-08T17:07:32Z

Codex Review: Didn't find any major issues. Can't wait for the next one!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

etraut-openai · 2025-11-08T17:09:06Z

Thanks again for the contribution! It's merged, and this will be included in the next release.

claude bot force-pushed the claude/session-011CUZfNELWrGVKPvRLvCmGt branch from fddd1e0 to d471b75 Compare October 28, 2025 20:54

etraut-openai and others added 3 commits November 3, 2025 23:10

Merge branch 'main' into claude/session-011CUZfNELWrGVKPvRLvCmGt

5c23d49

Merge branch 'main' into claude/session-011CUZfNELWrGVKPvRLvCmGt

d62bc8e

chore: run cargo fmt on approval_overlay.rs

1f25cf2

Format code according to project style guidelines.

etraut-openai and others added 4 commits November 4, 2025 11:20

Merge branch 'main' into claude/session-011CUZfNELWrGVKPvRLvCmGt

9526de4

Merge branch 'main' into claude/session-011CUZfNELWrGVKPvRLvCmGt

760efd0

0xRaduan and others added 2 commits November 5, 2025 11:28

fix: update missing exec_approval_modal_exec snapshot

b499084

Update the snapshot for exec_approval_emits_proposed_command_and_decision_history test that was missed in the previous commit. This snapshot also needs to show keyboard shortcuts in parentheses.

Merge branch 'main' into claude/session-011CUZfNELWrGVKPvRLvCmGt

44eb9b5

etraut-openai added the needs-response Additional information is requested label Nov 5, 2025

etraut-openai removed the needs-response Additional information is requested label Nov 8, 2025

etraut-openai approved these changes Nov 8, 2025

View reviewed changes

etraut-openai merged commit 5beb616 into openai:main Nov 8, 2025
25 checks passed

github-actions bot locked and limited conversation to collaborators Nov 8, 2025

openai unlocked this conversation Nov 8, 2025

feat(tui): Display keyboard shortcuts inline for approval options #5889

feat(tui): Display keyboard shortcuts inline for approval options #5889

Uh oh!

Conversation

0xRaduan commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xRaduan commented Oct 28, 2025

Uh oh!

0xRaduan commented Oct 28, 2025

Uh oh!

chatgpt-codex-connector bot commented Oct 28, 2025

Uh oh!

0xRaduan commented Oct 28, 2025

Uh oh!

chatgpt-codex-connector bot commented Oct 28, 2025

Uh oh!

0xRaduan commented Oct 28, 2025

Uh oh!

etraut-openai commented Nov 4, 2025

Uh oh!

chatgpt-codex-connector bot commented Nov 4, 2025

Uh oh!

0xRaduan commented Nov 4, 2025

Uh oh!

0xRaduan commented Nov 5, 2025

Uh oh!

etraut-openai commented Nov 5, 2025

Uh oh!

etraut-openai commented Nov 5, 2025

Uh oh!

0xRaduan commented Nov 8, 2025

Uh oh!

etraut-openai commented Nov 8, 2025

Uh oh!

chatgpt-codex-connector bot commented Nov 8, 2025

Uh oh!

Uh oh!

etraut-openai commented Nov 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

0xRaduan commented Oct 28, 2025 •

edited

Loading

github-actions bot commented Oct 28, 2025 •

edited

Loading