Pretty plugin labels, preserve plugin app provenance during MCP tool refresh#15606
Draft
canvrno-oai wants to merge 1 commit intomainfrom
Draft
Pretty plugin labels, preserve plugin app provenance during MCP tool refresh#15606canvrno-oai wants to merge 1 commit intomainfrom
canvrno-oai wants to merge 1 commit intomainfrom
Conversation
…gin_display_names before plugin name dedup
canvrno-oai
commented
Mar 24, 2026
Comment on lines
+1553
to
+1560
| loaded_plugin.manifest_name = manifest | ||
| .interface | ||
| .as_ref() | ||
| .and_then(|interface| interface.display_name.as_deref()) | ||
| .map(str::trim) | ||
| .filter(|display_name| !display_name.is_empty()) | ||
| .map(str::to_string) | ||
| .or_else(|| Some(manifest.name.clone())); |
Contributor
Author
There was a problem hiding this comment.
Use display_name, manifest.name as falback
canvrno-oai
commented
Mar 24, 2026
Comment on lines
+8988
to
+8990
| plugin_display_names: plugin_provenance | ||
| .plugin_display_names_for_connector_id(connector_id) | ||
| .to_vec(), |
Contributor
Author
There was a problem hiding this comment.
Prevent on_list_mcp_tools from clobbering display names, which complicated downstream dedup of apps/plugins.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
interface.displayNamefor plugin labels.list_mcp_toolsso connectorplugin_display_namesare not clobbered.