tui: add ephemeral /btw side-question threads by charley-oai · Pull Request #14506 · openai/codex

charley-oai · 2026-03-12T19:46:32Z

Summary

add a /btw slash command that forks the current thread into an isolated side-question child
keep BTW threads out of normal agent navigation and discard them when returning to the parent or switching away
add BTW footer copy plus TUI tests and snapshot coverage

Testing

cargo test -p codex-tui
just fix -p codex-tui
just fmt

Bazel was failing the BTW app tests before they reached any BTW logic because the test helper tried to probe a real terminal on stdout. Add a test-only TUI constructor with synthetic terminal state and route the BTW app tests through it so they no longer depend on an interactive terminal. Co-authored-by: Codex <noreply@openai.com>

charley-oai · 2026-03-13T14:06:39Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1909889d0a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/app.rs

charley-oai · 2026-03-13T15:08:38Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6170eda3ce

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/app.rs

charley-oai · 2026-03-13T15:22:22Z

@codex review this

chatgpt-codex-connector · 2026-03-13T15:32:34Z

Codex Review: Didn't find any major issues. Delightful!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Bazel was failing the BTW app tests before they reached any BTW logic because the test helper tried to probe a real terminal on stdout. Add a test-only TUI constructor with synthetic terminal state and route the BTW app tests through it so they no longer depend on an interactive terminal. Co-authored-by: Codex <noreply@openai.com>

charley-oai · 2026-03-15T07:49:11Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

codex/codex-rs/tui/src/app.rs

Lines 2456 to 2462 in 324aa33

    
               if let Err(err) = app.handle_active_thread_event(tui, event).await { 
        
                   break Err(err); 
        
               } 
        
           } else { 
        
               app.clear_active_thread().await; 
        
           } 
        
           AppRunControl::Continue

Propagate shutdown-complete exit from active thread handler

handle_active_thread_event now returns AppRunControl and emits Exit(UserRequested) after the tracked ShutdownComplete, but the main select-loop ignores that return value and always continues. This prevents ExitMode::ShutdownFirst from actually exiting on shutdown completion in the real app loop.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

charley-oai · 2026-03-16T05:14:58Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 48b240cd92

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/app/btw.rs

Bazel was failing the BTW app tests before they reached any BTW logic because the test helper tried to probe a real terminal on stdout. Add a test-only TUI constructor with synthetic terminal state and route the BTW app tests through it so they no longer depend on an interactive terminal. Co-authored-by: Codex <noreply@openai.com>

charley-oai · 2026-03-16T05:47:40Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a466f20732

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/app/btw.rs

charley-oai · 2026-03-16T06:27:57Z

@codex review this

chatgpt-codex-connector · 2026-03-16T06:38:09Z

Codex Review: Didn't find any major issues. Delightful!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Bazel was failing the BTW app tests before they reached any BTW logic because the test helper tried to probe a real terminal on stdout. Add a test-only TUI constructor with synthetic terminal state and route the BTW app tests through it so they no longer depend on an interactive terminal. Co-authored-by: Codex <noreply@openai.com>

charley-oai · 2026-03-16T07:48:45Z

@codex review this

chatgpt-codex-connector · 2026-03-16T07:59:06Z

Codex Review: Didn't find any major issues. Swish!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

charley-oai · 2026-03-16T17:24:25Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 31df052227

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/app/btw.rs

charley-oai · 2026-03-16T19:43:18Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b4e56ca00a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/app/btw.rs

Bazel was failing the BTW app tests before they reached any BTW logic because the test helper tried to probe a real terminal on stdout. Add a test-only TUI constructor with synthetic terminal state and route the BTW app tests through it so they no longer depend on an interactive terminal. Co-authored-by: Codex <noreply@openai.com>

Implement /btw as an ephemeral forked side-thread flow in the TUI and the mirrored tui_app_server frontend. The branch adds BTW thread lifecycle and navigation handling, uses interrupted-snapshot forks when needed, keeps BTW threads hidden from normal agent navigation, routes BTW prompts to the model, and mirrors the footer/fork-banner UI plus replay-only fallback behavior in the app-server variant. Co-authored-by: Codex <noreply@openai.com>

Co-authored-by: Codex <noreply@openai.com>

Resolve the remaining API and test drift after restacking the /btw implementation onto current main. - align tui /btw with ForkSnapshot-based forking - adapt tui_app_server BTW attachment to the current session/turn cache model - make BTW fork banners deterministic even for unnamed parent threads - clean up the stale thread_manager test import from the cherry-pick Co-authored-by: Codex <noreply@openai.com>

charley-oai · 2026-03-24T03:06:03Z

@codex review

chatgpt-codex-connector

💡 Codex Review

codex/codex-rs/tui_app_server/src/app.rs

Lines 4928 to 4929 in 5731998

    
           self.select_agent_thread(tui, app_server, primary_thread_id) 
        
               .await?;

Use BTW-aware switch path during shutdown failover

When a BTW child closes unexpectedly, failover switches with select_agent_thread(...) instead of select_agent_thread_and_discard_btw_chain(...). That bypasses BTW cleanup, leaving entries in btw_threads/thread_event_channels after switching away. Hidden ephemeral threads can retain stale per-thread state (e.g., pending approvals) until a full reset.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Co-authored-by: Codex <noreply@openai.com>

charley-oai · 2026-03-24T04:39:29Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8a67c3f5c6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/app/btw.rs

- add a live-thread fork path for pathless ephemeral threads - use it for direct TUI /btw and /fork - allow app-server thread/fork from ephemeral source threads Co-authored-by: Codex <noreply@openai.com>

charley-oai · 2026-03-24T06:30:46Z

@codex review

chatgpt-codex-connector

💡 Codex Review

codex/codex-rs/tui_app_server/src/app.rs

Lines 1457 to 1464 in 86fe197

    
           async fn shutdown_current_thread(&mut self, app_server: &mut AppServerSession) { 
        
               if let Some(thread_id) = self.chat_widget.thread_id() { 
        
                   // Clear any in-flight rollback guard when switching threads. 
        
                   self.backtrack.pending_rollback = None; 
        
                   if let Err(err) = app_server.thread_unsubscribe(thread_id).await { 
        
                       tracing::warn!("failed to unsubscribe thread {thread_id}: {err}"); 
        
                   } 
        
                   self.abort_thread_event_listener(thread_id);

Unsubscribe full BTW chain when replacing app-server session

This shutdown path only unsubscribes the active thread. After nested /btw, /fork and /resume call this and then clear local thread maps, so hidden BTW ancestors are no longer tracked but remain subscribed/running on the app server. That violates the discard-on-switch behavior and can leak background thread activity.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-03-24T06:42:20Z

codex-rs/core/src/thread_manager.rs

+                if matches!(source_status, AgentStatus::Running) {
+                    append_interrupted_boundary(history, /*turn_id*/ None)


Recompute turn state before adding interrupted fork boundary

fork_thread_from_thread gates ForkSnapshot::Interrupted on a stale source_status read before live_fork_history(). If the source thread completes between those awaits, status can still be Running and this appends an Interrupted boundary to already-complete history, producing an incorrect aborted turn in the fork.

Useful? React with 👍 / 👎.

Co-authored-by: Codex <noreply@openai.com>

charley-oai changed the title ~~tui: make /btw threads ephemeral~~ tui: add ephemeral /btw side-question threads Mar 13, 2026

github-actions bot mentioned this pull request Mar 13, 2026

📊 AI CLI 工具社区动态日报 2026-03-13 gsscsd/big_model_radar#27

Open

chatgpt-codex-connector bot reviewed Mar 13, 2026

View reviewed changes

codex-rs/tui/src/app.rs Outdated Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Mar 13, 2026

View reviewed changes

codex-rs/tui/src/app.rs Outdated Show resolved Hide resolved

charley-oai force-pushed the ccunningham/btw-ephemeral-subagent branch from dff7305 to 869c5d2 Compare March 15, 2026 07:27

chatgpt-codex-connector bot reviewed Mar 15, 2026

View reviewed changes

github-actions bot mentioned this pull request Mar 16, 2026

📊 AI CLI 工具社区动态日报 2026-03-16 gsscsd/big_model_radar#43

Open

chatgpt-codex-connector bot reviewed Mar 16, 2026

View reviewed changes

codex-rs/tui/src/app/btw.rs Outdated Show resolved Hide resolved

charley-oai force-pushed the ccunningham/btw-ephemeral-subagent branch from ffac786 to a466f20 Compare March 16, 2026 05:39

chatgpt-codex-connector bot reviewed Mar 16, 2026

View reviewed changes

codex-rs/tui/src/app/btw.rs Outdated Show resolved Hide resolved

charley-oai force-pushed the ccunningham/btw-ephemeral-subagent branch from 89aa63f to 68f5479 Compare March 16, 2026 06:45

charley-oai marked this pull request as ready for review March 16, 2026 15:59

charley-oai marked this pull request as draft March 16, 2026 16:02

chatgpt-codex-connector bot reviewed Mar 16, 2026

View reviewed changes

codex-rs/tui/src/app/btw.rs Outdated Show resolved Hide resolved

codex-rs/tui/src/app/btw.rs Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Mar 16, 2026

View reviewed changes

codex-rs/tui/src/app/btw.rs Outdated Show resolved Hide resolved

charley-oai force-pushed the ccunningham/btw-ephemeral-subagent branch from b4e56ca to 5570788 Compare March 17, 2026 03:44

charley-oai force-pushed the ccunningham/btw-ephemeral-subagent branch 2 times, most recently from 2be24f1 to 8ec8f95 Compare March 17, 2026 10:31

charley-oai and others added 3 commits March 23, 2026 19:29

Fix BTW argument-comment lint

28680fc

Co-authored-by: Codex <noreply@openai.com>

charley-oai force-pushed the ccunningham/btw-ephemeral-subagent branch from a519259 to 5731998 Compare March 24, 2026 02:59

chatgpt-codex-connector bot reviewed Mar 24, 2026

View reviewed changes

charley-oai and others added 2 commits March 23, 2026 20:46

tui: tighten BTW plumbing and test support

c2f63fd

Co-authored-by: Codex <noreply@openai.com>

tui-app-server: discard BTW chain on failover

8a67c3f

Co-authored-by: Codex <noreply@openai.com>

chatgpt-codex-connector bot reviewed Mar 24, 2026

View reviewed changes

codex-rs/tui/src/app/btw.rs Outdated Show resolved Hide resolved

Keep BTW forks ephemeral in direct TUI

86fe197

- add a live-thread fork path for pathless ephemeral threads - use it for direct TUI /btw and /fork - allow app-server thread/fork from ephemeral source threads Co-authored-by: Codex <noreply@openai.com>

chatgpt-codex-connector bot reviewed Mar 24, 2026

View reviewed changes

codex: fix CI failure on PR #14506

67331b6

Co-authored-by: Codex <noreply@openai.com>

	if let Err(err) = app.handle_active_thread_event(tui, event).await {
	break Err(err);
	}
	} else {
	app.clear_active_thread().await;
	}
	AppRunControl::Continue

	self.select_agent_thread(tui, app_server, primary_thread_id)
	.await?;

	async fn shutdown_current_thread(&mut self, app_server: &mut AppServerSession) {
	if let Some(thread_id) = self.chat_widget.thread_id() {
	// Clear any in-flight rollback guard when switching threads.
	self.backtrack.pending_rollback = None;
	if let Err(err) = app_server.thread_unsubscribe(thread_id).await {
	tracing::warn!("failed to unsubscribe thread {thread_id}: {err}");
	}
	self.abort_thread_event_listener(thread_id);

		if matches!(source_status, AgentStatus::Running) {
		append_interrupted_boundary(history, /turn_id/ None)

Conversation

charley-oai commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Testing

Uh oh!

charley-oai commented Mar 13, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

charley-oai commented Mar 13, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

charley-oai commented Mar 13, 2026

Uh oh!

chatgpt-codex-connector bot commented Mar 13, 2026

Uh oh!

charley-oai commented Mar 15, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

charley-oai commented Mar 16, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

charley-oai commented Mar 16, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

charley-oai commented Mar 16, 2026

Uh oh!

chatgpt-codex-connector bot commented Mar 16, 2026

Uh oh!

charley-oai commented Mar 16, 2026

Uh oh!

chatgpt-codex-connector bot commented Mar 16, 2026

Uh oh!

charley-oai commented Mar 16, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

charley-oai commented Mar 16, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

charley-oai commented Mar 24, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

charley-oai commented Mar 24, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

charley-oai commented Mar 12, 2026 •

edited

Loading