Create postnatalDay #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stevevanhooser would you be willing to also add the term "gestational day" to this PR ? |
|
Hi @lzehl - There is already a term called embryonic day: Sounds like a synonym? I am open to the term. Not sure how to express it alongside embryonic day. Although I guess gestationalAge might imply that the organism is being carried by a parent whereas embryonic day is uncertain (could be in a dish or a parent). |
|
you may be right. I will discuss with the ontology team next week. We can do another PR for this one then if needed. |
lzehl
requested changes
Mar 22, 2024
| "knowledgeSpaceLink": null, | ||
| "name": "postnatal day", | ||
| "preferredOntologyIdentifier": null, | ||
| "synonym": null |
There was a problem hiding this comment.
I would add ["P"] here as synonym and delete the second sentence from the definition.
|
Done! Also added the .jsonld file extension. |
fixing synonyms (has to be a list, and capitalization changes are not considered as synonyms, but we do currently enter abbreviations there)
added usage of abbreviation to definition
lzehl
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds postnatal day as a unit of measure