-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GTP sodium salt (NaGTP) #23
Conversation
}, | ||
"@id": "https://openminds.ebrains.eu/instances/molecularEntity/GTPDisodiumSalt", | ||
"@type": "https://openminds.ebrains.eu/controlledTerms/MolecularEntity", | ||
"definition": "Guanosine 5'-triphosphate (GTP) sodium salt hydrate.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we adjust this similarly to the MgATP instance?
Suggestion:
"A GTP (guanosine 5'-triphosphate) molecule bonded with two sodium ions (Na+) forming a salt hydrate."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
"description": null, | ||
"interlexIdentifier": null, | ||
"knowledgeSpaceLink": null, | ||
"name": "GTP, Disodium salt", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think disodium should not be capitalized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The capitalisation matches the PubChem entry, but I agree.
"interlexIdentifier": null, | ||
"knowledgeSpaceLink": null, | ||
"name": "GTP, Disodium salt", | ||
"preferredOntologyIdentifier": null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The MgATP instance states the pubchem references as preferred ID. Could you please add, the one from your description here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PubChem isn't an ontology, but I've followed your suggestion until we can find a better entry. I can't find the sodium salt of GTP in ChEBI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think that was the logic that @lzehl used for MgATP.
Encountered as "NaGTP", a search for this term led to this product page which then led to this PubChem page