Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GTP sodium salt (NaGTP) #23

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Add GTP sodium salt (NaGTP) #23

merged 2 commits into from
Apr 19, 2024

Conversation

apdavison
Copy link
Member

@apdavison apdavison commented Mar 10, 2024

Encountered as "NaGTP", a search for this term led to this product page which then led to this PubChem page

},
"@id": "https://openminds.ebrains.eu/instances/molecularEntity/GTPDisodiumSalt",
"@type": "https://openminds.ebrains.eu/controlledTerms/MolecularEntity",
"definition": "Guanosine 5'-triphosphate (GTP) sodium salt hydrate.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we adjust this similarly to the MgATP instance?

Suggestion:
"A GTP (guanosine 5'-triphosphate) molecule bonded with two sodium ions (Na+) forming a salt hydrate."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

"description": null,
"interlexIdentifier": null,
"knowledgeSpaceLink": null,
"name": "GTP, Disodium salt",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think disodium should not be capitalized.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The capitalisation matches the PubChem entry, but I agree.

"interlexIdentifier": null,
"knowledgeSpaceLink": null,
"name": "GTP, Disodium salt",
"preferredOntologyIdentifier": null,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The MgATP instance states the pubchem references as preferred ID. Could you please add, the one from your description here?

Add: https://pubchem.ncbi.nlm.nih.gov/compound/135818278

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PubChem isn't an ontology, but I've followed your suggestion until we can find a better entry. I can't find the sodium salt of GTP in ChEBI.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think that was the logic that @lzehl used for MgATP.

@UlrikeS91 UlrikeS91 merged commit ee07d96 into main Apr 19, 2024
1 of 2 checks passed
@UlrikeS91 UlrikeS91 deleted the more-chem branch April 19, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants