Fix search filter for topics on openHPI

openHPI · Oct 6, 2021 · b7c8e39 · b7c8e39
1 parent 9425ccc
commit b7c8e39
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 14 deletions.
diff --git a/Common/Base.lproj/Localizable.strings b/Common/Base.lproj/Localizable.strings
@@ -26,12 +26,9 @@
 /* Title for target audience filter (sap) */
 "course-list.search.filter.title.target audience" = "Target Audience";
 
-/* Title for topic filter (sap) */
+/* Title for topic filter (hpi + sap) */
 "course-list.search.filter.title.topic" = "Topic";
 
-/* Title for track filter (hpi) */
-"course-list.search.filter.title.track" = "Track";
-
 /* explanation how to achieve the certificate */
 "course.certificates.explanation.confirmationOfParticipation" = "A confirmation of participation is issued to those who have completed at least %d%% of the course material.";
 

diff --git a/Common/Branding/CourseClassifierSearchFilters.swift b/Common/Branding/CourseClassifierSearchFilters.swift
@@ -11,21 +11,18 @@ public struct CourseClassifierSearchFilters: Decodable {
 }
 
 public enum CourseClassifierSearchFilterType: String, Decodable {
-    case track
     case targetAudience
     case proficiencyLevel
     case topic
 
     public var displayName: String {
         switch self {
-        case .track:
-            return CommonLocalizedString("course-list.search.filter.title.track", comment: "Title for track filter (hpi)")
         case .targetAudience:
             return CommonLocalizedString("course-list.search.filter.title.target audience", comment: "Title for target audience filter (sap)")
         case .proficiencyLevel:
             return CommonLocalizedString("course-list.search.filter.title.proficiency level", comment: "Title for proficiency level filter (who)")
         case .topic:
-            return CommonLocalizedString("course-list.search.filter.title.topic", comment: "Title for topic filter (sap)")
+            return CommonLocalizedString("course-list.search.filter.title.topic", comment: "Title for topic filter (hpi + sap)")
         }
     }
 }
diff --git a/Common/de.lproj/Localizable.strings b/Common/de.lproj/Localizable.strings
@@ -26,12 +26,9 @@
 /* Title for target audience filter (sap) */
 "course-list.search.filter.title.target audience" = "Zielgruppe";
 
-/* Title for topic filter (sap) */
+/* Title for topic filter (hpi + sap) */
 "course-list.search.filter.title.topic" = "Thema";
 
-/* Title for track filter (hpi) */
-"course-list.search.filter.title.track" = "Kategorie";
-
 /* explanation how to achieve the certificate */
 "course.certificates.explanation.confirmationOfParticipation" = "Die Teilnahmebestätigung erhält, wer auf zumindest %d%% der Kursunterlagen zugegriffen hat.";
 

diff --git a/...ing/openHPI/assets-ios-brand.xcassets/BrandConfiguration.dataset/BrandConfiguration.plist b/...ing/openHPI/assets-ios-brand.xcassets/BrandConfiguration.dataset/BrandConfiguration.plist
@@ -53,8 +53,8 @@
 	</dict>
 	<key>courseClassifierSearchFilters</key>
 	<dict>
-		<key>category</key>
-		<string>track</string>
+		<key>topic</key>
+		<string>topic</string>
 	</dict>
 	<key>additionalLearningMaterial</key>
 	<array>