Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pylint from 3.0.3 to 3.1.0 #9

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 26, 2024

Bumps pylint from 3.0.3 to 3.1.0.

Commits
  • 053c2c3 Bump pylint to 3.1.0, update changelog
  • c954636 Upgrade release documentation, and contributors.txt
  • 7300ed2 Discover .pyi files (#9241)
  • 9dbf3df Merge maintenance 3.0.x into main following 3.0.4 release (#9459)
  • 28e89b0 Remove changelog fragments pertaining to 3.0.4
  • 4332ea1 Merge branch 'maintenance/3.0.x' into main following 3.0.4 release
  • 8115381 Bump pylint to 3.0.4, update changelog (#9458)
  • 4bf3524 [false-negative] Fix for consider-using-min/max-builtin (#9127)
  • 8c24b1e [pre-commit.ci] pre-commit autoupdate (#9448)
  • f499686 Update astroid version to 3.1.0 (#9457)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [pylint](https://github.com/pylint-dev/pylint) from 3.0.3 to 3.1.0.
- [Release notes](https://github.com/pylint-dev/pylint/releases)
- [Commits](pylint-dev/pylint@v3.0.3...v3.1.0)

---
updated-dependencies:
- dependency-name: pylint
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file python pip / Python-related dependency upgrades labels Feb 26, 2024
@Dome-GER Dome-GER merged commit 009ae45 into main Feb 26, 2024
@dependabot dependabot bot deleted the dependabot/pip/pylint-3.1.0 branch February 26, 2024 12:49
@MatthiasWiesner
Copy link
Contributor

@Dome-GER Please do not merge pull requests. There are no unit tests at all. And if a library changes, than the source code can entirly break. But you will only recognize it when the code is deployed to production!

@Dome-GER
Copy link
Member

Dome-GER commented Feb 26, 2024

It would be scary if bumping a static code analyzer breaks something in the application. ;) But I'm happy to leave it to someone else.

@MatthiasWiesner
Copy link
Contributor

E.g. There is the pull request: #4
That changed the python version from 3.9 to 3.12 in the Dockerfile

I tried to build a docker image (via github action) but it failed:

#14 2.925           long_description = open(os.path.join(BASE_PATH, 'README.rst'), 'U').read()
#14 2.925                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

The 'U' flag is depricated since python 3.1 but was removed in python 3.11. This time the build failed, since this code is part of the setup prcedure.
Can you imagine what happens if a arbitrary python library in the Pipfile.lock changes? A function/method may changes but not the call. And since there are no unit test, the docker image will be created and deployed to production. Only then the error will occur.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file python pip / Python-related dependency upgrades
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants