Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Golangci Lint v1.61 #686

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Fix Golangci Lint v1.61 #686

merged 1 commit into from
Sep 11, 2024

Conversation

mpass99
Copy link
Contributor

@mpass99 mpass99 commented Sep 11, 2024

@mpass99 mpass99 requested a review from MrSerth September 11, 2024 12:04
@mpass99 mpass99 self-assigned this Sep 11, 2024
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 37.93103% with 18 lines in your changes missing coverage. Please review.

Project coverage is 76.17%. Comparing base (ca655a8) to head (6d9f93e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/environment/nomad_environment.go 40.00% 9 Missing and 3 partials ⚠️
internal/runner/nomad_runner.go 25.00% 2 Missing and 1 partial ⚠️
pkg/monitoring/influxdb2_middleware.go 0.00% 2 Missing ⚠️
internal/nomad/command_execution.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #686      +/-   ##
==========================================
- Coverage   76.42%   76.17%   -0.25%     
==========================================
  Files          43       43              
  Lines        3618     3631      +13     
==========================================
+ Hits         2765     2766       +1     
- Misses        624      632       +8     
- Partials      229      233       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@MrSerth MrSerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the article and for fixing; that was a good read (for me 🤗).

@MrSerth MrSerth merged commit 62cddd5 into main Sep 11, 2024
11 of 12 checks passed
@MrSerth MrSerth deleted the linter branch September 11, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants