Optimize SetRunnerMetaUsed

to send a second request to Nomad only when the meta values change.
openHPI · Sep 12, 2024 · b42819b · b42819b
1 parent 31299f4
commit b42819b
Showing 1 changed file with 17 additions and 9 deletions.
diff --git a/internal/nomad/nomad.go b/internal/nomad/nomad.go
@@ -176,21 +176,29 @@ func (a *APIClient) LoadRunnerJobs(environmentID dto.EnvironmentID) ([]*nomadApi
 }
 
 func (a *APIClient) SetRunnerMetaUsed(runnerID string, used bool, duration int) error {
+	newMetaUsedValue := ConfigMetaUsedValue
+	if !used {
+		newMetaUsedValue = ConfigMetaUnusedValue
+	}
+	newMetaTimeoutValue := strconv.Itoa(duration)
+
 	job, err := a.job(runnerID)
 	if err != nil {
 		return fmt.Errorf("couldn't retrieve job info: %w", err)
 	}
 	configTaskGroup := FindAndValidateConfigTaskGroup(job)
-	if used {
-		configTaskGroup.Meta[ConfigMetaUsedKey] = ConfigMetaUsedValue
-		configTaskGroup.Meta[ConfigMetaTimeoutKey] = strconv.Itoa(duration)
-	} else {
-		configTaskGroup.Meta[ConfigMetaUsedKey] = ConfigMetaUnusedValue
-	}
+	metaUsedDiffers := configTaskGroup.Meta[ConfigMetaUsedKey] != newMetaUsedValue
+	metaTimeoutDiffers := configTaskGroup.Meta[ConfigMetaTimeoutKey] != newMetaTimeoutValue
 
-	_, err = a.RegisterNomadJob(job)
-	if err != nil {
-		return fmt.Errorf("couldn't update runner config: %w", err)
+	if metaUsedDiffers || (used && metaTimeoutDiffers) {
+		configTaskGroup.Meta[ConfigMetaUsedKey] = newMetaUsedValue
+		if used {
+			configTaskGroup.Meta[ConfigMetaTimeoutKey] = newMetaTimeoutValue
+		}
+		_, err = a.RegisterNomadJob(job)
+		if err != nil {
+			return fmt.Errorf("couldn't update runner config: %w", err)
+		}
 	}
 	return nil
 }