Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor pvm memory #257

Merged
merged 7 commits into from
Jan 2, 2025
Merged

refactor pvm memory #257

merged 7 commits into from
Jan 2, 2025

Conversation

qiweiii
Copy link
Contributor

@qiweiii qiweiii commented Dec 27, 2024

close #240

Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 87.14919% with 87 lines in your changes missing coverage. Please review.

Project coverage is 77.22%. Comparing base (667f5b3) to head (cb38eb8).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
PolkaVM/Sources/PolkaVM/Memory.swift 82.55% 71 Missing ⚠️
.../Blockchain/VMInvocations/HostCall/HostCalls.swift 0.00% 8 Missing ⚠️
PolkaVM/Sources/PolkaVM/VMState.swift 0.00% 5 Missing ⚠️
...s/Blockchain/VMInvocations/HostCall/HostCall.swift 0.00% 1 Missing ⚠️
PolkaVM/Sources/PolkaVM/Instruction.swift 0.00% 1 Missing ⚠️
PolkaVM/Sources/PolkaVM/StandardProgram.swift 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #257      +/-   ##
==========================================
+ Coverage   76.08%   77.22%   +1.14%     
==========================================
  Files         284      285       +1     
  Lines       22250    22740     +490     
==========================================
+ Hits        16928    17561     +633     
+ Misses       5322     5179     -143     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qiweiii qiweiii marked this pull request as ready for review December 31, 2024 07:52
@xlc xlc merged commit 74b0ab5 into master Jan 2, 2025
5 checks passed
@xlc xlc deleted the update-pvm-memory branch January 2, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update pvm memory implementation
2 participants