Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update consts and general merklization #254

Merged
merged 6 commits into from
Dec 20, 2024
Merged

Update consts and general merklization #254

merged 6 commits into from
Dec 20, 2024

Conversation

qiweiii
Copy link
Contributor

@qiweiii qiweiii commented Dec 19, 2024

based on 0.5.2

@qiweiii qiweiii marked this pull request as ready for review December 19, 2024 10:20
xlc
xlc previously approved these changes Dec 19, 2024
View reviewed changes
Utils/Tests/UtilsTests/Merklization/MerklizationTests.swift Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Dec 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 75.49%. Comparing base (1e86e55) to head (d2c8de2).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...tils/Sources/Utils/Merklization/Merklization.swift 87.87% 4 Missing ⚠️
...ain/Sources/Blockchain/Config/ProtocolConfig.swift 83.33% 1 Missing ⚠️
...ces/Blockchain/RuntimeProtocols/Guaranteeing.swift 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #254      +/-   ##
==========================================
- Coverage   75.60%   75.49%   -0.11%     
==========================================
  Files         283      283              
  Lines       22100    22187      +87     
==========================================
+ Hits        16709    16751      +42     
- Misses       5391     5436      +45

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qiweiii qiweiii merged commit 78027de into master Dec 20, 2024
4 of 5 checks passed
@qiweiii qiweiii deleted the update-merkle branch December 20, 2024 03:04
MacOMNI added a commit that referenced this pull request Dec 23, 2024
@MacOMNI
Merge branch 'master' into dev-guaranteeringservice
ee9bc21 
* master:
  increase sleep
  Disputes (#256)
  Update consts and general merklization (#254)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xlc xlc xlc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qiweiii @xlc