Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix stream bug #248

Merged
merged 2 commits into from
Dec 12, 2024
Merged

fix stream bug #248

merged 2 commits into from
Dec 12, 2024

Conversation

MacOMNI
Copy link
Contributor

@MacOMNI MacOMNI commented Dec 11, 2024

No description provided.

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 98.78049% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.37%. Comparing base (ccaedb9) to head (0320019).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...ing/Tests/MsQuicSwiftTests/QuicListenerTests.swift 98.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #248      +/-   ##
==========================================
+ Coverage   76.20%   76.37%   +0.16%     
==========================================
  Files         267      267              
  Lines       20604    20683      +79     
==========================================
+ Hits        15702    15796      +94     
+ Misses       4902     4887      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xlc
Copy link
Member

xlc commented Dec 11, 2024

can you try to write a test to reproduce the error

@MacOMNI
Copy link
Contributor Author

MacOMNI commented Dec 11, 2024

can you try to write a test to reproduce the error

I wil try it

@MacOMNI MacOMNI marked this pull request as ready for review December 12, 2024 01:58
@xlc xlc merged commit c9838bc into master Dec 12, 2024
5 checks passed
@xlc xlc deleted the dev-stream-issue branch December 12, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants