a basic telemetry rpc #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiweiii
commented
Oct 22, 2024
| try await chainDataProvider.getState(hash: hash) | ||
| } | ||
|
|
||
| public func getPeersCount() async throws -> Int { |
There was a problem hiding this comment.
Not sure what network info we should expose, and is it only one peer per node?
There was a problem hiding this comment.
the Peer class is our own peer server, we can get number of connections from it as there should only be one connections per remote peer
xlc
reviewed
Oct 24, 2024
| @@ -20,10 +21,39 @@ struct ChainHandler { | |||
| throw JSONError(code: -32602, message: "Invalid block hash") | |||
| } | |||
| let block = try await source.getBlock(hash: data32) | |||
| return block.map { ["hash": $0.hash.description, "parentHash": $0.header.parentHash.description] } | |||
| return block.map { [ | |||
There was a problem hiding this comment.
just return block, which implements Encodable
xlc
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for connect to jam dashboard's telemetry dashboard