Skip to content

Conversation

@c1ly
Copy link
Contributor

@c1ly c1ly commented Jan 9, 2026

  • Moved the validations tests outside of otap-dataflow to directly under the rust directory
  • Added pipeline support to run pipelines and validate the output
  • Allows for multiple pipelines to be defined and added to the validation test, currently only supports non transformative processors

@github-actions github-actions bot added the rust Pull requests that update Rust code label Jan 9, 2026
@codecov
Copy link

codecov bot commented Jan 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.80%. Comparing base (05ea7a9) to head (7e2517e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1751      +/-   ##
==========================================
- Coverage   84.33%   81.80%   -2.53%     
==========================================
  Files         495      181     -314     
  Lines      144232    51480   -92752     
==========================================
- Hits       121640    42114   -79526     
+ Misses      22058     8832   -13226     
  Partials      534      534              
Components Coverage Δ
otap-dataflow ∅ <ø> (∅)
query_abstraction 80.61% <ø> (ø)
query_engine 90.17% <ø> (-0.35%) ⬇️
syslog_cef_receivers ∅ <ø> (∅)
otel-arrow-go 53.50% <ø> (ø)
quiver ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@c1ly c1ly marked this pull request as ready for review January 12, 2026 23:39
@c1ly c1ly requested a review from a team as a code owner January 12, 2026 23:39
@github-actions github-actions bot added the ci-repo Repository maintenance, build, GH workflows, repo cleanup, or other chores label Jan 13, 2026
@albertlockett
Copy link
Member

albertlockett commented Jan 14, 2026

going to try closing and reopening to trigger CI

edit: this didn't work

@albertlockett
Copy link
Member

@drewrelmas any idea why this PR is not running the rust CI job?

I assume we have some checks in place that this needs to run for any changes under the rust/ directory.

It looks like this should run for any pull request targeting main, so I'm confused about why this isn't running.

permissions:
contents: read
on:
push:
branches:
- main
pull_request:
branches:
- main
merge_group:

strategy:
fail-fast: false
fail-fast: false
matrix:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be a matrix strategy if only processing one folder? Also, there are duplicate fail-fast definitions here - that could be why the Rust-CI didn't run.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@albertlockett See the comment here about fail-fast, I think this is the issue with the CI.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch, thanks @drewrelmas!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-repo Repository maintenance, build, GH workflows, repo cleanup, or other chores rust Pull requests that update Rust code

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants