-
Notifications
You must be signed in to change notification settings - Fork 67
add pipeline support to validation tests #1751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1751 +/- ##
==========================================
- Coverage 84.33% 81.80% -2.53%
==========================================
Files 495 181 -314
Lines 144232 51480 -92752
==========================================
- Hits 121640 42114 -79526
+ Misses 22058 8832 -13226
Partials 534 534
🚀 New features to boost your workflow:
|
|
going to try closing and reopening to trigger CI edit: this didn't work |
|
@drewrelmas any idea why this PR is not running the rust CI job? I assume we have some checks in place that this needs to run for any changes under the rust/ directory. It looks like this should run for any pull request targeting main, so I'm confused about why this isn't running. otel-arrow/.github/workflows/rust-ci.yml Lines 2 to 12 in 31f3a17
|
.github/workflows/rust-ci.yml
Outdated
| strategy: | ||
| fail-fast: false | ||
| fail-fast: false | ||
| matrix: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be a matrix strategy if only processing one folder? Also, there are duplicate fail-fast definitions here - that could be why the Rust-CI didn't run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@albertlockett See the comment here about fail-fast, I think this is the issue with the CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great catch, thanks @drewrelmas!
Uh oh!
There was an error while loading. Please reload this page.