PeriodicReader - alternate shutdown implementation #2482
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternate way of handling shutdown - this just sends a message to the background thread to initiate shutdown, and wait for thread handle to join.
The handle.join() has some risks - as shutdown could get block indefinitely if the background thread is stuck in a export, and we cannot enforce timeout :(
An alternative way would be keep the existing way, but enforce recv_timeout, so that shutdown always ends in a fixed time, no matter whether background is stuck or not. Will send a PR with this approach as well, but either way, if a rogue exporter is used, background thread is still stuck. All we can ensure is shutdown gets a timed exit. (esp. important since shutdown can be triggered automatically when Drop() occurs...)
Not for merge, but to have a discussion about various approaches.