Skip to content

Conversation

@utpilla
Copy link
Contributor

@utpilla utpilla commented May 20, 2024

Changes

I created another PR on my fork where I intentionally make a breaking change to a public enum variant to ensure that this check catches it: https://github.com/utpilla/opentelemetry-rust/actions/runs/9166338802/job/25201536158?pr=2#step:4:59

@utpilla utpilla requested a review from a team May 20, 2024 23:36
@codecov
Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.1%. Comparing base (cb149bf) to head (052210c).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1793   +/-   ##
=====================================
  Coverage   74.1%   74.1%           
=====================================
  Files        125     125           
  Lines      19481   19481           
=====================================
  Hits       14452   14452           
  Misses      5029    5029           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. A critical CI check once we hit 1.0, or even the 1st RC release!

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@cijothomas cijothomas merged commit 5c17ed1 into open-telemetry:main May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants