feat(google-genai): add instrumentation to supplied tool call functions #3446
+824
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
assigned alizenhom, codefromthecrypt, gyliu513, karthikscale3, lmolkova, lzchen and nirga
github-actions
bot
requested review from
alizenhom,
codefromthecrypt,
gyliu513,
karthikscale3,
lmolkova,
lzchen and
nirga
michaelsafyan
changed the title
This was referenced Apr 25, 2025
|
Updated the logic here to record the information only on span attributes and not in log events per feedback out-of-band. |
aabmass
reviewed
May 16, 2025
...rumentation-google-genai/src/opentelemetry/instrumentation/google_genai/tool_call_wrapper.py
Show resolved
Hide resolved
...rumentation-google-genai/src/opentelemetry/instrumentation/google_genai/tool_call_wrapper.py
Show resolved
Hide resolved
...rumentation-google-genai/src/opentelemetry/instrumentation/google_genai/tool_call_wrapper.py
Show resolved
Hide resolved
...rumentation-google-genai/src/opentelemetry/instrumentation/google_genai/tool_call_wrapper.py
Outdated
Show resolved
Hide resolved
...rumentation-google-genai/src/opentelemetry/instrumentation/google_genai/tool_call_wrapper.py
Outdated
Show resolved
Hide resolved
...emetry-instrumentation-google-genai/tests/generate_content/test_tool_call_instrumentation.py
Outdated
Show resolved
Hide resolved
aabmass
approved these changes
May 19, 2025
...rumentation-google-genai/src/opentelemetry/instrumentation/google_genai/tool_call_wrapper.py
Outdated
Show resolved
Hide resolved
…ai/src/opentelemetry/instrumentation/google_genai/tool_call_wrapper.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enhances the
google-genaiinstrumentation library by automatically adding instrumentation to supplied tool call functions. The instrumentation logic causes supplied tool call functions to emit both spans and log events.Type of change
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.