-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Ingress for extensions #3441
base: main
Are you sure you want to change the base?
Conversation
It's a POC and work is still in progress. Once the code for extension service is merged, this branch will be re-based. |
1e1bc2f
to
6e44119
Compare
Signed-off-by: Ankit152 <[email protected]>
Folks since the service for extensions is merged, I would like to discuss about the implementation of Ingress. cc @pavolloffay @iblancasa @swiatekm @jaronoff97 @yurishkuro |
Signed-off-by: Ankit152 <[email protected]>
The change looks fine to me. What I'm not convinced of is whether we need a whole separate configuration vs a boolean switch to include extension ports in the existing Ingress. I'd like to discuss that in the issue. |
Sure @swiatekm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Folks since the service for extensions is merged, I would like to discuss about the implementation of Ingress.
We can put it on the agenda for the SIG call if you like.
Can a boolean work when the extension may changes? |
Not sure what you mean? A boolean switch would mean we'd just add the extension paths to the existing receiver Ingress. |
hey @Ankit152, the contribution was discussed in the SIG call today. There three things came up:
|
Description:
Link to tracking Issue(s):
Testing:
Documentation: