Javadoc site crawler #7300
Javadoc site crawler #7300
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7300 +/- ##
============================================
- Coverage 90.03% 90.03% -0.01%
+ Complexity 6916 6915 -1
============================================
Files 787 787
Lines 20864 20864
Branches 2023 2023
============================================
- Hits 18785 18784 -1
Misses 1441 1441
- Partials 638 639 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| tasks { | ||
| withType<JavaCompile>().configureEach { | ||
| sourceCompatibility = "17" | ||
| targetCompatibility = "17" |
There was a problem hiding this comment.
What java 17 features are you using?
There was a problem hiding this comment.
text blocks which are 15+
There was a problem hiding this comment.
this reminded me that we could use a record class too maybe not
There was a problem hiding this comment.
Ah, text blocks used in the test. Seems fine, given that 1. this is internal project tooling 2. the project requires builds to use java 17.
| if (response.statusCode() != 200) { | ||
| logger.log( | ||
| Level.SEVERE, "Unexpected response code: " + response.statusCode() + ": " + response); | ||
| throw new IOException("Unable to pull Maven central artifacts list"); |
There was a problem hiding this comment.
Might help to print the response status code and body (if available)
There was a problem hiding this comment.
do you mean adding it to the IOException message along with the log?
There was a problem hiding this comment.
Oh I missed that the logging. Between the logging and the IOException I think we're covered
Resolves #7294