-
Notifications
You must be signed in to change notification settings - Fork 940
Prototype: User facing logs API (including emit event) #6761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
b6ea470
Prototype: User facing logs API (including emit event)
trask ee5a5b7
no-op default
trask 6556acf
Change EventBuilder put to setBody
trask 59862e4
Add convenience value builder
trask 43066d0
Rename ValueBuilder to ValueMapBuilder and add ValueListBuilder
trask 7e5809a
simplify
trask File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
api/all/src/main/java/io/opentelemetry/api/common/ValueListBuilder.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| /* | ||
| * Copyright The OpenTelemetry Authors | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| package io.opentelemetry.api.common; | ||
|
|
||
| public interface ValueListBuilder { | ||
|
|
||
| ValueListBuilder add(Value<?> value); | ||
|
|
||
| Value<?> build(); | ||
| } |
25 changes: 25 additions & 0 deletions
25
api/all/src/main/java/io/opentelemetry/api/common/ValueListBuilderImpl.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| /* | ||
| * Copyright The OpenTelemetry Authors | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| package io.opentelemetry.api.common; | ||
|
|
||
| import java.util.ArrayList; | ||
| import java.util.List; | ||
|
|
||
| class ValueListBuilderImpl implements ValueListBuilder { | ||
|
|
||
| private final List<Value<?>> values = new ArrayList<>(); | ||
|
|
||
| @Override | ||
| public ValueListBuilder add(Value<?> value) { | ||
| values.add(value); | ||
| return this; | ||
| } | ||
|
|
||
| @Override | ||
| public Value<?> build() { | ||
| return Value.of(values.toArray(new Value<?>[0])); | ||
| } | ||
| } |
33 changes: 33 additions & 0 deletions
33
api/all/src/main/java/io/opentelemetry/api/common/ValueMapBuilder.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| /* | ||
| * Copyright The OpenTelemetry Authors | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| package io.opentelemetry.api.common; | ||
|
|
||
| public interface ValueMapBuilder { | ||
|
|
||
| default ValueMapBuilder put(String key, String value) { | ||
| put(key, Value.of(value)); | ||
| return this; | ||
| } | ||
|
|
||
| default ValueMapBuilder put(String key, long value) { | ||
| put(key, Value.of(value)); | ||
| return this; | ||
| } | ||
|
|
||
| default ValueMapBuilder put(String key, double value) { | ||
| put(key, Value.of(value)); | ||
| return this; | ||
| } | ||
|
|
||
| default ValueMapBuilder put(String key, boolean value) { | ||
| put(key, Value.of(value)); | ||
| return this; | ||
| } | ||
|
|
||
| ValueMapBuilder put(String key, Value<?> value); | ||
|
|
||
| Value<?> build(); | ||
| } |
25 changes: 25 additions & 0 deletions
25
api/all/src/main/java/io/opentelemetry/api/common/ValueMapBuilderImpl.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| /* | ||
| * Copyright The OpenTelemetry Authors | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| package io.opentelemetry.api.common; | ||
|
|
||
| import java.util.ArrayList; | ||
| import java.util.List; | ||
|
|
||
| class ValueMapBuilderImpl implements ValueMapBuilder { | ||
|
|
||
| private final List<KeyValue> keyValues = new ArrayList<>(); | ||
|
|
||
| @Override | ||
| public ValueMapBuilder put(String key, Value<?> value) { | ||
| keyValues.add(KeyValue.of(key, value)); | ||
| return this; | ||
| } | ||
|
|
||
| @Override | ||
| public Value<?> build() { | ||
| return Value.of(keyValues.toArray(new KeyValue[0])); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.