Skip to content

Bandit: Add the request_path to the span name #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joshk wants to merge 1 commit into from
Closed

Bandit: Add the request_path to the span name #401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion instrumentation/opentelemetry_bandit/lib/opentelemetry_bandit.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ defmodule OpentelemetryBandit do
name =
if request_method == HTTPAttributes.http_request_method_values().other,
do: :HTTP,
else: request_method
else: String.trim("#{request_method} #{conn.request_path}")

if public_endpoint?(conn, config) do
propagated_ctx =
Expand Down
16 changes: 8 additions & 8 deletions instrumentation/opentelemetry_bandit/test/bandit/opentelemetry_bandit_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ defmodule OpentelemetryBanditTest do

assert_receive {:span,
span(
name: :GET,
name: "GET /hello",
kind: :server,
attributes: span_attrs,
parent_span_id: 13_235_353_014_750_950_193
Expand Down Expand Up @@ -117,7 +117,7 @@ defmodule OpentelemetryBanditTest do

assert_receive {:span,
span(
name: :GET,
name: "GET /hello",
kind: :server,
links: links,
parent_span_id: :undefined
Expand Down Expand Up @@ -152,7 +152,7 @@ defmodule OpentelemetryBanditTest do

assert_receive {:span,
span(
name: :GET,
name: "GET /hello",
kind: :server,
links: links,
parent_span_id: :undefined
Expand All @@ -171,7 +171,7 @@ defmodule OpentelemetryBanditTest do

assert_receive {:span,
span(
name: :GET,
name: "GET /hello",
kind: :server,
parent_span_id: 13_235_353_014_750_950_193
)}
Expand Down Expand Up @@ -208,7 +208,7 @@ defmodule OpentelemetryBanditTest do

assert_receive {:span,
span(
name: :GET,
name: "GET /with_body",
attributes: span_attrs
)}

Expand Down Expand Up @@ -332,7 +332,7 @@ defmodule OpentelemetryBanditTest do

assert_receive {:span,
span(
name: :GET,
name: "GET /hello",
kind: :server,
attributes: span_attrs
)}
Expand Down Expand Up @@ -381,7 +381,7 @@ defmodule OpentelemetryBanditTest do

assert_receive {:span,
span(
name: :GET,
name: "GET /arithmetic_error",
attributes: span_attrs,
events: events,
status: ^expected_status
Expand Down Expand Up @@ -428,7 +428,7 @@ defmodule OpentelemetryBanditTest do

assert_receive {:span,
span(
name: :GET,
name: "GET /halted",
kind: :server,
attributes: span_attrs,
status: ^expected_status
Expand Down