Skip to content

Conversation

@marctc
Copy link
Contributor

@marctc marctc commented Nov 26, 2025

Current implementation only captures IP of database connections, which ultimately
are set as outgoing. This PR adds a probe to sql.Open to capture hostname of database.

@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.86%. Comparing base (a3ce1ee) to head (9c01efe).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
pkg/ebpf/common/dsn_parser.go 78.26% 3 Missing and 2 partials ⚠️
pkg/ebpf/common/spanner.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #935      +/-   ##
==========================================
+ Coverage   55.81%   55.86%   +0.04%     
==========================================
  Files         255      256       +1     
  Lines       22107    22166      +59     
==========================================
+ Hits        12340    12382      +42     
- Misses       8929     8943      +14     
- Partials      838      841       +3     
Flag Coverage Δ
integration-test 22.85% <0.00%> (-0.15%) ⬇️
integration-test-arm 0.00% <0.00%> (ø)
integration-test-vm-${ARCH}-${KERNEL_VERSION} 0.00% <0.00%> (?)
k8s-integration-test 2.67% <0.00%> (-0.01%) ⬇️
oats-test 0.00% <0.00%> (ø)
unittests 47.15% <66.66%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@grcevski
Copy link
Contributor

I wonder if it's possible to pull the name out from another place than open. Open typically happens once for the application lifecycle and I'm worried this will only work if OBI sees the start of the application.

@marctc
Copy link
Contributor Author

marctc commented Nov 27, 2025

I wonder if it's possible to pull the name out from another place than open. Open typically happens once for the application lifecycle and I'm worried this will only work if OBI sees the start of the application.

Oh, that's actually a good point, didn't think about it! Let me invesitgate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants