-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[documentation] Fix links #2423
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
infra
Infra work - CI/CD, code coverage, linters
documentation
Improvements or additions to documentation
labels
Dec 16, 2024
Kielek
force-pushed
the
links-checker
branch
from
December 16, 2024 11:22
acb689c
to
0de57ca
Compare
github-actions
bot
requested review from
CodeBlanch,
ejsmith,
IliaBrahinets,
maldago,
matt-hensley,
pcwiese,
ppittle,
rajkumar-rangaraj,
srprash,
xsoheilalizadeh and
Yun-Ting
December 16, 2024 11:22
github-actions
bot
added
comp:extensions.aws
Things related to OpenTelemetry.Extensions.AWS
comp:instrumentation.aspnet
Things related to OpenTelemetry.Instrumentation.AspNet
comp:instrumentation.aspnetcore
Things related to OpenTelemetry.Instrumentation.AspNetCore
comp:instrumentation.cassandra
Things related to OpenTelemetry.Instrumentation.Cassandra
comp:instrumentation.elasticsearchclient
Things related to OpenTelemetry.Instrumentation.ElasticsearchClient
comp:instrumentation.entityframeworkcore
Things related to OpenTelemetry.Instrumentation.EntityFrameworkCore
comp:instrumentation.grpccore
Things related to OpenTelemetry.Instrumentation.GrpcCore
comp:instrumentation.grpcnetclient
Things related to OpenTelemetry.Instrumentation.GrpcNetClient
comp:instrumentation.http
Things related to OpenTelemetry.Instrumentation.Http
comp:instrumentation.masstransit
Things related to OpenTelemetry.Instrumentation.MassTransit
comp:instrumentation.mysqldata
Things related to OpenTelemetry.Instrumentation.MySqlData
comp:instrumentation.owin
Things related to OpenTelemetry.Instrumentation.Owin
comp:instrumentation.process
Things related to OpenTelemetry.Instrumentation.Process
comp:instrumentation.quartz
Things related to OpenTelemetry.Instrumentation.Quartz
comp:instrumentation.sqlclient
Things related to OpenTelemetry.Instrumentation.SqlClient
comp:instrumentation.stackexchangeredis
Things related to OpenTelemetry.Instrumentation.StackExchangeRedis
labels
Dec 16, 2024
github-actions
bot
added
the
comp:persistentstorage.filesystem
Things related to OpenTelemetry.PersistentStorage.FileSystem
label
Dec 16, 2024
Kielek
force-pushed
the
links-checker
branch
from
December 16, 2024 11:36
0de57ca
to
1e6f985
Compare
github-actions
bot
added
the
comp:exporter.influxdb
Things related to OpenTelemetry.Exporter.InfluxDB
label
Dec 16, 2024
Kielek
force-pushed
the
links-checker
branch
from
December 16, 2024 11:37
1e6f985
to
f5e3952
Compare
CodeBlanch
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rajkumar-rangaraj
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp:exporter.influxdb
Things related to OpenTelemetry.Exporter.InfluxDB
comp:extensions.aws
Things related to OpenTelemetry.Extensions.AWS
comp:instrumentation.aspnet
Things related to OpenTelemetry.Instrumentation.AspNet
comp:instrumentation.aspnetcore
Things related to OpenTelemetry.Instrumentation.AspNetCore
comp:instrumentation.cassandra
Things related to OpenTelemetry.Instrumentation.Cassandra
comp:instrumentation.elasticsearchclient
Things related to OpenTelemetry.Instrumentation.ElasticsearchClient
comp:instrumentation.entityframeworkcore
Things related to OpenTelemetry.Instrumentation.EntityFrameworkCore
comp:instrumentation.grpccore
Things related to OpenTelemetry.Instrumentation.GrpcCore
comp:instrumentation.grpcnetclient
Things related to OpenTelemetry.Instrumentation.GrpcNetClient
comp:instrumentation.http
Things related to OpenTelemetry.Instrumentation.Http
comp:instrumentation.masstransit
Things related to OpenTelemetry.Instrumentation.MassTransit
comp:instrumentation.mysqldata
Things related to OpenTelemetry.Instrumentation.MySqlData
comp:instrumentation.owin
Things related to OpenTelemetry.Instrumentation.Owin
comp:instrumentation.process
Things related to OpenTelemetry.Instrumentation.Process
comp:instrumentation.quartz
Things related to OpenTelemetry.Instrumentation.Quartz
comp:instrumentation.sqlclient
Things related to OpenTelemetry.Instrumentation.SqlClient
comp:instrumentation.stackexchangeredis
Things related to OpenTelemetry.Instrumentation.StackExchangeRedis
comp:persistentstorage.filesystem
Things related to OpenTelemetry.PersistentStorage.FileSystem
documentation
Improvements or additions to documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Rason: I wanted to fix one of the problematic link, but also considered CI for this.
Links checker.
It takes a lot of time for each run. We can consider adding it as a cron. IMO no need to include in every md modification.
Failing only on non-published packages: https://github.com/open-telemetry/opentelemetry-dotnet-contrib/actions/runs/12351829730/job/34467628274
Merge requirement checklist
[ ] Unit tests added/updated[ ] AppropriateCHANGELOG.md
files updated for non-trivial changes[ ] Changes in public API reviewed (if applicable)