Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[documentation] Fix links #2423

Merged
merged 2 commits into from
Dec 16, 2024
Merged

[documentation] Fix links #2423

merged 2 commits into from
Dec 16, 2024

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Dec 16, 2024

Changes

Rason: I wanted to fix one of the problematic link, but also considered CI for this.
Links checker.

It takes a lot of time for each run. We can consider adding it as a cron. IMO no need to include in every md modification.

Failing only on non-published packages: https://github.com/open-telemetry/opentelemetry-dotnet-contrib/actions/runs/12351829730/job/34467628274

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • [ ] Unit tests added/updated
  • [ ] Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

@github-actions github-actions bot added infra Infra work - CI/CD, code coverage, linters documentation Improvements or additions to documentation labels Dec 16, 2024
@github-actions github-actions bot added comp:extensions.aws Things related to OpenTelemetry.Extensions.AWS comp:instrumentation.aspnet Things related to OpenTelemetry.Instrumentation.AspNet comp:instrumentation.aspnetcore Things related to OpenTelemetry.Instrumentation.AspNetCore comp:instrumentation.cassandra Things related to OpenTelemetry.Instrumentation.Cassandra comp:instrumentation.elasticsearchclient Things related to OpenTelemetry.Instrumentation.ElasticsearchClient comp:instrumentation.entityframeworkcore Things related to OpenTelemetry.Instrumentation.EntityFrameworkCore comp:instrumentation.grpccore Things related to OpenTelemetry.Instrumentation.GrpcCore comp:instrumentation.grpcnetclient Things related to OpenTelemetry.Instrumentation.GrpcNetClient comp:instrumentation.http Things related to OpenTelemetry.Instrumentation.Http comp:instrumentation.masstransit Things related to OpenTelemetry.Instrumentation.MassTransit comp:instrumentation.mysqldata Things related to OpenTelemetry.Instrumentation.MySqlData comp:instrumentation.owin Things related to OpenTelemetry.Instrumentation.Owin comp:instrumentation.process Things related to OpenTelemetry.Instrumentation.Process comp:instrumentation.quartz Things related to OpenTelemetry.Instrumentation.Quartz comp:instrumentation.sqlclient Things related to OpenTelemetry.Instrumentation.SqlClient comp:instrumentation.stackexchangeredis Things related to OpenTelemetry.Instrumentation.StackExchangeRedis labels Dec 16, 2024
@github-actions github-actions bot added the comp:persistentstorage.filesystem Things related to OpenTelemetry.PersistentStorage.FileSystem label Dec 16, 2024
@github-actions github-actions bot requested a review from Havret December 16, 2024 11:36
@github-actions github-actions bot added the comp:exporter.influxdb Things related to OpenTelemetry.Exporter.InfluxDB label Dec 16, 2024
@github-actions github-actions bot removed the infra Infra work - CI/CD, code coverage, linters label Dec 16, 2024
@Kielek Kielek changed the title Links checker [documentation] Fix links Dec 16, 2024
@Kielek Kielek marked this pull request as ready for review December 16, 2024 11:52
@Kielek Kielek requested a review from a team as a code owner December 16, 2024 11:52
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kielek Kielek merged commit 46e0c60 into open-telemetry:main Dec 16, 2024
53 checks passed
@Kielek Kielek deleted the links-checker branch December 16, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:exporter.influxdb Things related to OpenTelemetry.Exporter.InfluxDB comp:extensions.aws Things related to OpenTelemetry.Extensions.AWS comp:instrumentation.aspnet Things related to OpenTelemetry.Instrumentation.AspNet comp:instrumentation.aspnetcore Things related to OpenTelemetry.Instrumentation.AspNetCore comp:instrumentation.cassandra Things related to OpenTelemetry.Instrumentation.Cassandra comp:instrumentation.elasticsearchclient Things related to OpenTelemetry.Instrumentation.ElasticsearchClient comp:instrumentation.entityframeworkcore Things related to OpenTelemetry.Instrumentation.EntityFrameworkCore comp:instrumentation.grpccore Things related to OpenTelemetry.Instrumentation.GrpcCore comp:instrumentation.grpcnetclient Things related to OpenTelemetry.Instrumentation.GrpcNetClient comp:instrumentation.http Things related to OpenTelemetry.Instrumentation.Http comp:instrumentation.masstransit Things related to OpenTelemetry.Instrumentation.MassTransit comp:instrumentation.mysqldata Things related to OpenTelemetry.Instrumentation.MySqlData comp:instrumentation.owin Things related to OpenTelemetry.Instrumentation.Owin comp:instrumentation.process Things related to OpenTelemetry.Instrumentation.Process comp:instrumentation.quartz Things related to OpenTelemetry.Instrumentation.Quartz comp:instrumentation.sqlclient Things related to OpenTelemetry.Instrumentation.SqlClient comp:instrumentation.stackexchangeredis Things related to OpenTelemetry.Instrumentation.StackExchangeRedis comp:persistentstorage.filesystem Things related to OpenTelemetry.PersistentStorage.FileSystem documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants