Optimize Metric Processing for Single Collector with Delta Temporality #3236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
lalitb
changed the title
lalitb
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3236 +/- ##
==========================================
+ Coverage 87.78% 87.80% +0.02%
==========================================
Files 198 198
Lines 6308 6324 +16
==========================================
+ Hits 5537 5552 +15
- Misses 771 772 +1
|
lalitb
changed the title
lalitb
changed the title
marcalff
reviewed
Jan 13, 2025
Comment on lines
55
to
56
| if (collectors.size() == 1 && collector->GetAggregationTemporality( | ||
| instrument_descriptor_.type_) == AggregationTemporality::kDelta) |
There was a problem hiding this comment.
Nit: use the aggregation_temporarily local variable, from the previous line, in the if test.
marcalff
reviewed
Jan 13, 2025
| return true; | ||
| }); | ||
|
|
||
| return callback(metric_data); |
There was a problem hiding this comment.
No idea if this can happen or not, does the code in the fast path needs to pay attention to previous metrics in unreported_metrics_ ?
If not, consider to add a comment to explain why, and/or an assert to make sure there are no unreported metrics.
There was a problem hiding this comment.
The fast-path doesn't need to consider the unreported_metrics, I have added comments to make it clear.
ThomsonTan
reviewed
Jan 21, 2025
ThomsonTan
reviewed
Jan 22, 2025
ThomsonTan
approved these changes
Jan 22, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a fast path for cases with a single collector/reader using delta temporality. It skips unnecessary intermediate processing and directly generates metrics for callback, reducing memory usage and CPU overhead. This change is supposed to improve performance for common single-collector scenarios while retaining existing functionality for other cases.
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes